[PATCH libdrm 0/4] amdgpu: use amdgpu_cs_submit_raw2 for amdgpu tests

Luben Tuikov luben.tuikov at amd.com
Tue Feb 11 23:28:36 UTC 2020


Looks fine to me as well. Just as Christian said, would have to be approved by
Marek.

Regards,
Luben

On 2020-02-11 9:57 a.m., Deucher, Alexander wrote:
> Yes, correct.
> 
> Alex
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> *From:* Huang, Ray <Ray.Huang at amd.com>
> *Sent:* Tuesday, February 11, 2020 9:35 AM
> *To:* Deucher, Alexander <Alexander.Deucher at amd.com>; Christian König <ckoenig.leichtzumerken at gmail.com>; amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>
> *Cc:* Pelloux-prayer, Pierre-eric <Pierre-eric.Pelloux-prayer at amd.com>; Olsak, Marek <Marek.Olsak at amd.com>; Liu, Aaron <Aaron.Liu at amd.com>; Tuikov, Luben <Luben.Tuikov at amd.com>; Koenig, Christian <Christian.Koenig at amd.com>
> *Subject:* RE: [PATCH libdrm 0/4] amdgpu: use amdgpu_cs_submit_raw2 for amdgpu tests
>  
> 
> [AMD Public Use]
> 
>  
> 
> Hi Alex,
> 
>  
> 
> MR = merge request?  Should I create account to send merge request in the freedesktop gitlab?
> 
>  
> 
> Thanks,
> 
> Ray
> 
>  
> 
> *From:* Deucher, Alexander <Alexander.Deucher at amd.com>
> *Sent:* Tuesday, February 11, 2020 10:30 PM
> *To:* Christian König <ckoenig.leichtzumerken at gmail.com>; Huang, Ray <Ray.Huang at amd.com>; amd-gfx at lists.freedesktop.org
> *Cc:* Pelloux-prayer, Pierre-eric <Pierre-eric.Pelloux-prayer at amd.com>; Olsak, Marek <Marek.Olsak at amd.com>; Liu, Aaron <Aaron.Liu at amd.com>; Tuikov, Luben <Luben.Tuikov at amd.com>; Koenig, Christian <Christian.Koenig at amd.com>
> *Subject:* Re: [PATCH libdrm 0/4] amdgpu: use amdgpu_cs_submit_raw2 for amdgpu tests
> 
>  
> 
> [AMD Public Use]
> 
>  
> 
> Also, libdrm changes should go through a gitlab MR now.
> 
>  
> 
> Alex
> 
>  
> 
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> 
> *From:*Christian König <ckoenig.leichtzumerken at gmail.com <mailto:ckoenig.leichtzumerken at gmail.com>>
> *Sent:* Tuesday, February 11, 2020 6:39 AM
> *To:* Huang, Ray <Ray.Huang at amd.com <mailto:Ray.Huang at amd.com>>; amd-gfx at lists.freedesktop.org <mailto:amd-gfx at lists.freedesktop.org><amd-gfx at lists.freedesktop.org <mailto:amd-gfx at lists.freedesktop.org>>
> *Cc:* Pelloux-prayer, Pierre-eric <Pierre-eric.Pelloux-prayer at amd.com <mailto:Pierre-eric.Pelloux-prayer at amd.com>>; Olsak, Marek <Marek.Olsak at amd.com <mailto:Marek.Olsak at amd.com>>; Liu, Aaron <Aaron.Liu at amd.com <mailto:Aaron.Liu at amd.com>>; Tuikov, Luben <Luben.Tuikov at amd.com <mailto:Luben.Tuikov at amd.com>>; Deucher, Alexander <Alexander.Deucher at amd.com <mailto:Alexander.Deucher at amd.com>>; Koenig, Christian <Christian.Koenig at amd.com <mailto:Christian.Koenig at amd.com>>
> *Subject:* Re: [PATCH libdrm 0/4] amdgpu: use amdgpu_cs_submit_raw2 for amdgpu tests
> 
>  
> 
> Looks good on first glance, but Marek and/or Pierre can probably better
> judge than me.
> 
> Christian.
> 
> Am 11.02.20 um 12:22 schrieb Huang Rui:
>> So far, the amdgpu_cs_submit_raw2 is used for MesaGL, however the amdgpu tests
>> still use the legacy interface. So we would like to make amdgpu tests verify the
>> amdgpu_cs_submit_raw2 API.
>>
>> Thanks,
>> Ray
>>
>> Huang Rui (4):
>>    amdgpu: use alloca for dependencies and sem_dependencies
>>    amdgpu: use amdgpu_cs_submit_raw2 in amdgpu_cs_submit
>>    amdgpu: remove the un-used chunk_array
>>    amdgpu: clean up the cs structure variable
>>
>>   amdgpu/amdgpu_cs.c | 36 +++++++++++++-----------------------
>>   1 file changed, 13 insertions(+), 23 deletions(-)
>>
> 



More information about the amd-gfx mailing list