[PATCH] tracedump: add --help and --function-histogram

José Fonseca jose.r.fonseca at gmail.com
Thu Oct 20 06:58:18 PDT 2011


On Thu, Oct 20, 2011 at 3:43 AM, Carl Worth <cworth at cworth.org> wrote:
> On Wed, 7 Sep 2011 16:40:55 +0100, José Fonseca <jose.r.fonseca at gmail.com> wrote:
>> I envision "git style" CLI, i.e., "<tool> <command> <args> ...", e.g.:
>>
>>   apitrace dump foo.trace
>>   apitrace stats foo.trace
>>   apitrace reenc foo.trace
>
> I've started hacking on exactly this. The branch I have so far (with
> only "apitrace trace" and "apitrace help" so far) can be found at:
>
>        http://git.cworth.org/git/apitrace
>
> and cloned from:
>
>        git://git.cworth.org/git/apitrace
>
> I'll be glad to accept any comments on what I have already. But I'll
> probably be cleaning things up a bit (incorporating "apitrace dump" and
> a new "apitrace trim") before I seriously propose this for inclusion.
>
> I have not made an effort to make things work on anything but Linux. I'm
> not really in a position to fix/test other operating systems, but I'll
> be glad to accept any patches or proposals to improve the portability.

Carl,

Portability fixes will be needed as you admited, talloc dependency
removed as Zack mentioned, but implementation details apart, this is
the direction I'd like to take. So thanks for taking the initiative.

I'd prefer that you work on a branch on the main apitrace repos, so
that I can also collaborate, in particular non-Linux OS portability
fixes.  Do you have a github account?

About talloc replacement, the best is a simple C++ class for path
manipulation.  I actually started writing one to fix issue 46.

Getopt dependency is fine -- I'll just add the BSD getopt_long for
Windows as done in Mesa.

Jose


More information about the apitrace mailing list