[PATCH] tracedump: add --help and --function-histogram
zack at kde.org
Wed Sep 7 07:48:36 PDT 2011
On Wednesday, September 07, 2011 05:21:53 AM Alon Levy wrote:
> trace_parser.cpp | 11 +++++++++++
> trace_parser.hpp | 5 +++++
> tracedump.cpp | 20 ++++++++++++++++++--
> 3 files changed, 34 insertions(+), 2 deletions(-)
It's great to see you start contributing to the project. But FWIW I don't
think this is the right approach.
Most importantly parser shouldn't do any analysis of the trace. It's just too
crucial to have it do anything but parsing.
I'm not sure if having trace dump not do trace dumping in certain cases is a
good idea. I know you did it because there's no better place to put it right
now but I think a lot better approach would be to create a new tool, e.g.
tracestats, that would along the histogram dump average/min/max number of
calls per frame, size of data downloaded by the gpu on each frame and so on.
Finally, tbh, I'd vastly prefer if trace visualization would be done in the
gui rather than writing tools that keep doing the same thing gui is supposed
to be doing, but that might be just my preference.
More information about the apitrace