[PATCH] Fix crash when using apitrace trim's -o option.

Kenneth Graunke kenneth at whitecape.org
Thu Apr 5 10:51:26 PDT 2012


The -o option takes an argument (the filename), so the getopt string
needs to be 'o:', not 'o'.  Otherwise, no argument is parsed, optarg
remains NULL, and we crash on "output = optarg".
---
 cli/cli_trim.cpp |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/cli/cli_trim.cpp b/cli/cli_trim.cpp
index 2ea5251..206e24e 100644
--- a/cli/cli_trim.cpp
+++ b/cli/cli_trim.cpp
@@ -58,7 +58,7 @@ enum {
 };
 
 const static char *
-shortOptions = "ho";
+shortOptions = "ho:";
 
 const static struct option
 longOptions[] = {
-- 
1.7.7.6



More information about the apitrace mailing list