[PATCH] Add trim support to qapitrace GUI app

[Carl Worth]

On Thu, 15 Mar 2012 22:13:54 -0400, Zack Rusin <zack at kde.org> wrote:
> To be honest the ideal way that feature would be implemented would be
> if it actually trimmed the trace right in the view, i.e. clicking on a
> call and selecting "trim" would trim the trace in place and the edit
> menu would have get an "undo/restore original trace" option that would
> go back to the original trace.

That would definitely be a useful mode.

Dan's subsequent revision of patch series makes one step in that
direction by reloading the trimmed trace, but it doesn't yet provide an
"undo" operation so things are definitely not as usable as they could
be, (particularly with our current, lame trim implementation that
requires the user to iteratively search for a set of calls to trim that
actually work).

It occurs to me that we could get to a workflow with "trim and undo" but
without having to write much code by simply making the trim operation
invoke a new instance of the GUI.

That way, if the user is happy with the newly trimmed result, the user
can close the previous instance. And if the user isn't happy with the
trimmed result, the user can close the new instance while still having
the original set of calls selected in the original instance.

What do you think? Is that too cheesy of a hack?

-Carl

-- 
carl.d.worth at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/apitrace/attachments/20120413/f3a01838/attachment.pgp>