<div dir="ltr">Looks alright AFAICT.<div><br></div><div><div>Is there a repos I can pull this from and start testing? (It's too time consuming for me to apply long patch series from email.)</div><div>
<div><br></div><div>Jose</div></div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, May 19, 2013 at 3:39 PM, Alexander Monakov <span dir="ltr"><<a href="mailto:amonakov@ispras.ru" target="_blank">amonakov@ispras.ru</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br>
<br>
These patches improve stack recording on ELF platforms by using libbacktrace<br>
(and libbfd for demangling).  The first patch is a small cleanup to existing<br>
code.<br>
<br>
The last patch introduces a dependency on libbfd + demangle.h.  Should it be<br>
checked somehow in CMakeLists.txt?  Apart from that, libbacktrace has soft<br>
dependencies on dwarf.h and unwind.h, but will build without those (although<br>
common/trace_backtrace.* does not check BACKTRACE_SUPPORTED macro yet).<br>
<br>
Alexander<br>
<br>
 CMakeLists.txt             |   6 +<br>
 common/trace_backtrace.cpp | 278 ++++++++++++++++++---------------------------<br>
 common/trace_backtrace.hpp |  20 +---<br>
 wrappers/CMakeLists.txt    |   2 +<br>
 4 files changed, 118 insertions(+), 188 deletions(-)<br>
<br>
 thirdparty/libbacktrace/CMakeLists.txt           |  140 +<br>
 thirdparty/libbacktrace/ChangeLog                |  285 ++<br>
 thirdparty/libbacktrace/README                   |   23 +<br>
 thirdparty/libbacktrace/alloc.c                  |  140 +<br>
 thirdparty/libbacktrace/auxincl/dwarf2.h         |   52 +<br>
 thirdparty/libbacktrace/auxincl/filenames.h      |   40 +<br>
 thirdparty/libbacktrace/<a href="http://backtrace-supported.h.in" target="_blank">backtrace-supported.h.in</a> |   61 +<br>
 thirdparty/libbacktrace/backtrace.c              |  108 +<br>
 thirdparty/libbacktrace/backtrace.h              |  199 ++<br>
 thirdparty/libbacktrace/btest.c                  |  628 +++++<br>
 thirdparty/libbacktrace/config.h.in.cmake        |   21 +<br>
 thirdparty/libbacktrace/dwarf.c                  | 3007 ++++++++++++++++++++++<br>
 thirdparty/libbacktrace/elf.c                    |  904 +++++++<br>
 thirdparty/libbacktrace/fileline.c               |  208 ++<br>
 thirdparty/libbacktrace/internal.h               |  242 ++<br>
 thirdparty/libbacktrace/mmap.c                   |  264 ++<br>
 thirdparty/libbacktrace/mmapio.c                 |  100 +<br>
 thirdparty/libbacktrace/nounwind.c               |   66 +<br>
 thirdparty/libbacktrace/posix.c                  |  100 +<br>
 thirdparty/libbacktrace/print.c                  |   92 +<br>
 thirdparty/libbacktrace/read.c                   |   96 +<br>
 thirdparty/libbacktrace/simple.c                 |  108 +<br>
 thirdparty/libbacktrace/state.c                  |   72 +<br>
 thirdparty/libbacktrace/unknown.c                |   64 +<br>
 24 files changed, 7020 insertions(+)<br>
<br>
_______________________________________________<br>
apitrace mailing list<br>
<a href="mailto:apitrace@lists.freedesktop.org">apitrace@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/apitrace" target="_blank">http://lists.freedesktop.org/mailman/listinfo/apitrace</a><br>
</blockquote></div><br></div>