<div dir="ltr"><div class="gmail_default" style="font-family:'courier new',monospace;color:rgb(0,0,255)">Hi Jose,</div><div class="gmail_default" style="font-family:'courier new',monospace;color:rgb(0,0,255)"><br></div><div class="gmail_default" style="font-family:'courier new',monospace;color:rgb(0,0,255)">Yes it could be implemented as an option. I did in fact do that for Vogl if you want see an initial implementation and/or if it might be useful or worthwhile. Although the definition for State/Render groups <a href="https://github.com/lawlove/apitrace/commit/ad84ca057aa3ce007513560a78024bb6202b8375">proposed in apitrace</a> was <a href="https://github.com/ValveSoftware/vogl/pull/172">changed in Vogl</a>. Either definition could be implemented.</div><div class="gmail_extra"><br></div><div class="gmail_extra"><div class="gmail_default" style="font-family:'courier new',monospace;color:rgb(0,0,255)">The option settings there allow different views of the apicall tree including nested groups, debug marker groups (glPush/PopDebugGroup calls), state/render groups, combinations, or none (flat view).</div><div class="gmail_default" style="font-family:'courier new',monospace;color:rgb(0,0,255)"><br></div><div class="gmail_default" style="font-family:'courier new',monospace;color:rgb(0,0,255)">> <div class="gmail_default" style="display:inline"></div><span style="font-family:arial,sans-serif;color:rgb(34,34,34)">It might actually hinder comprehension as everything will look the same when collapsed.</span><br></div></div><div class="gmail_extra"><br></div><div class="gmail_extra"><div class="gmail_default" style="font-family:'courier new',monospace;color:rgb(0,0,255)">Yes, that could be. In Vogl's case the calls/groups are tied to a color-coded timeline so one can visualize where time is being spent. Additionally, clicking on the apicall tree will mark where in the timeline it's occurring. That may give it more usefulness.</div></div><div class="gmail_extra"><div class="gmail_default" style="font-family:'courier new',monospace;color:rgb(0,0,255)"></div></div><div class="gmail_extra"><div class="gmail_extra"><div class="gmail_default" style="font-family:'courier new',monospace;color:rgb(0,0,255)">(Vogl uses Qt5 but unfortunately I had problems adding Qt5 to my system and ended up uninstalling Qt4 although they should work together fine. At the time I just didn't want to spend any more time on it)</div></div><div class="gmail_default" style="font-family:'courier new',monospace;color:rgb(0,0,255)"><br></div><div class="gmail_extra"><div class="gmail_default" style="font-family:'courier new',monospace;color:rgb(0,0,255)">Thanks for the feedback.</div><div class="gmail_default" style="font-family:'courier new',monospace;color:rgb(0,0,255)">Larry</div></div><div class="gmail_extra"></div><div class="gmail_default" style="font-family:'courier new',monospace;color:rgb(0,0,255)"></div></div><div class="gmail_extra"><div class="gmail_quote">On Fri, Dec 12, 2014 at 2:13 PM, José Fonseca <span dir="ltr"><<a href="mailto:jose.r.fonseca@gmail.com" target="_blank">jose.r.fonseca@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Lawrence,<div><br></div><div>I see some value in this when analyzing traces from third-parties (eg, when qapitrace being used by OpenGL implementator to debug), but this might interfer with the application's glPush/PopDebugGroup calls (ie, qapitrace being used by OpenGL application developer).<div>
<br></div><div><div class="gmail_default" style="font-family:'courier new',monospace;color:rgb(0,0,255);display:inline"></div>It might acutually hinder comprehension as everything will look the same when collapsed.</div><div><br></div><div>Could this implemented as an option?</div><div><br></div><div>Jose<br><div class="gmail_extra"><br><br><div class="gmail_quote"><div><div class="h5">On Fri, Mar 28, 2014 at 1:47 AM, Lawrence Love <span dir="ltr"><<a href="mailto:lawlove@gmail.com" target="_blank">lawlove@gmail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><div class="h5"><div dir="ltr"><div>I'm not sure of the procedure - if a pull request is in order for feedback - but I have a commit I'd like to get feedback on for adding an extra level of branching for grouping calls into Render blocks and State changes blocks in addition to the existing glPush/PopDebugGroup groups. I've put the details in the <a href="https://github.com/lawlove/apitrace/commit/ad84ca057aa3ce007513560a78024bb6202b8375" target="_blank">commit message</a> and here is the repository:</div>
<div><br></div><a href="https://github.com/lawlove/apitrace/tree/gui-add-render-and-state-groups" target="_blank">https://github.com/lawlove/apitrace/tree/gui-add-render-and-state-groups</a><div><br></div><div>Also attached is a screen shot.</div>
<div><br></div><div>Thanks,</div><div>Larry<br><div><br></div><div><br></div></div></div>
<br></div></div>_______________________________________________<br>
apitrace mailing list<br>
<a href="mailto:apitrace@lists.freedesktop.org" target="_blank">apitrace@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/apitrace" target="_blank">http://lists.freedesktop.org/mailman/listinfo/apitrace</a><br>
<br></blockquote></div><br></div></div></div></div>
</blockquote></div><br></div></div>