[avahi] malformed ARP in avahi-0.6.18 to avahi-0.6.20

[Lennart Poettering]

On Sun, 05.08.07 18:22, Yeung, Pauline (Pauline.Yeung at sciatl.com) wrote:

Hi!

> I'm new to the lists, and I'm sure which lists should I report bugs.

Posting this to the avahi ML is fine, though I usually prefer if bugs
are posted through our bug tracking system:

http://avahi.org/wiki/AvahiCommunity#Patches

> I tested avahi-autoipd from release 0.6.18, 0.6.19 and 0.6.20 in two
> platforms, x86 running Linux 2.6.20-1.2962.fc6, and MIPS running
> linux 2.6.14.  In all 6 cases, the ARP packets are malformed when
> captured with "wireshark".
> 
> Here is the patch that fixed the problem.

Thank you!

> --- avahi-0.6.20.orig/avahi-autoipd/main.c 2007-08-05 15:05:19.000000000 -0700
> +++ avahi-0.6.20/avahi-autoipd/main.c 2007-08-05 15:05:40.000000000 -0700
> @@ -510,7 +510,7 @@
>      sa.sll_halen = ETHER_ADDRLEN;
>      memset(sa.sll_addr, 0xFF, ETHER_ADDRLEN);
> 
> -    if (sendto(fd, packet, packet_len, 0, (struct sockaddr*) &sa, sizeof(sa)) < 0) {
> +    if (sendto(fd, packet->ether_payload, packet_len, 0, (struct sockaddr*) &sa, sizeof(sa)) < 0) {


Ouch! This is a brown paperbag bug I guess, introduced by some FreeBSD
portability patches we recently merged.

Thank you very much for pointing this out!

Fixed in SVN r1503.

I guess it is time to release 2.6.21.

Thank you,

Lennart


-- 
Lennart Poettering                        Red Hat, Inc.
lennart [at] poettering [dot] net         ICQ# 11060553
http://0pointer.net/lennart/           GnuPG 0x1A015CC4