[Beignet] clGetDeviceIDs() called with mixed device type

[Xing, Homer]

I also think we should not report INVALID_DEVICE_TYPE for mixed device type ...

By mixed device types, the user wish to get one device from multiple choices, then the driver should return an available device, not return an error.

Best regards,
Homer

From: beignet-bounces+homer.xing=intel.com at lists.freedesktop.org [mailto:beignet-bounces+homer.xing=intel.com at lists.freedesktop.org] On Behalf Of Song, Ruiling
Sent: Tuesday, June 04, 2013 4:09 PM
To: beignet at lists.freedesktop.org
Subject: [Beignet] clGetDeviceIDs() called with mixed device type

In clGetDeviceIDs(). The device type is a bit-field value. But Spec does not say exactly whether masked value is allowed as input argument.
The problem is whether we should report an INVALID_DEVICE_TYPE when user passes (CL_DEVICE_TYPE_GPU | CL_DEVICE_TYPE_DEFAULT) or other kind of mixed device types. Beignet currently report INVALID_DEVICE_TYPE error.
Obviously piglit does not think so. It use mixed type to get available device number.
Personally, I agree with piglit. We should NOT report INVALID_DEVICE_TYPE for mixed device type. Any comments?

Thanks!
Ruiling

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/beignet/attachments/20130604/89343919/attachment-0001.html>