[Beignet] [PATCH] Fix several CL error code return bugs

Dag Lem dag at nimrod.no
Thu May 23 02:06:05 PDT 2013


Zhigang Gong <zhigang.gong at linux.intel.com> writes:

> LGTM. Pused. So after this commit, almost all the internal functions such as cl_xxx_xxx
> will get a non-null errcode_ret parameter, you may consider to make another patch
> to simplify those internal functions by using this assumption, thus we can remove
> the redundant parameter checking code.
>

I just tried to ensure that the little error checking that is done in
cl_api.c actually works and doesn't cause crashes. I'll leave error
handling in general to others.

All CL functions should really be refined to work according to spec. I
tried as best as I could to make the image functions I implemented work
according to spec (except for the missing event handling), but getting
all CL functions up to spec is a task which I can not undertake.

I see that He Junyan and Song Ruiling are looking into the current
shortcomings of Beignet's CL API implementation - hopefully they will
get things up to snuff.

-- 
Dag


More information about the Beignet mailing list