[Beignet] [PATCH] Fix store undef value assert.

Zhigang Gong zhigang.gong at linux.intel.com
Tue Sep 17 23:47:13 PDT 2013


LGTM, pushed, thanks.

On Wed, Sep 18, 2013 at 03:01:44PM +0800, Yang Rong wrote:
> 
> Signed-off-by: Yang Rong <rong.r.yang at intel.com>
> ---
>  backend/src/llvm/llvm_gen_backend.cpp | 19 +++++++++++++++++--
>  1 file changed, 17 insertions(+), 2 deletions(-)
> 
> diff --git a/backend/src/llvm/llvm_gen_backend.cpp b/backend/src/llvm/llvm_gen_backend.cpp
> index f1d63c5..5284ce5 100644
> --- a/backend/src/llvm/llvm_gen_backend.cpp
> +++ b/backend/src/llvm/llvm_gen_backend.cpp
> @@ -2480,7 +2480,13 @@ namespace gbe
>            // Build the tuple data in the vector
>            vector<ir::Register> tupleData; // put registers here
>            for (uint32_t elemID = 0; elemID < elemNum; ++elemID) {
> -            const ir::Register reg = this->getRegister(llvmValues, elemID);
> +            ir::Register reg;
> +            if(regTranslator.isUndefConst(llvmValues, elemID)) {
> +              Value *v = Constant::getNullValue(elemType);
> +              reg = this->getRegister(v);
> +            } else
> +              reg = this->getRegister(llvmValues, elemID);
> +
>              tupleData.push_back(reg);
>            }
>            const ir::Tuple tuple = ctx.arrayTuple(&tupleData[0], elemNum);
> @@ -2500,7 +2506,13 @@ namespace gbe
>              // Build the tuple data in the vector
>              vector<ir::Register> tupleData; // put registers here
>              for (uint32_t elemID = 0; elemID < 4; ++elemID) {
> -              const ir::Register reg = this->getRegister(llvmValues, 4*msg+elemID);
> +              ir::Register reg;
> +              if(regTranslator.isUndefConst(llvmValues, elemID)) {
> +                Value *v = Constant::getNullValue(elemType);
> +                reg = this->getRegister(v);
> +              } else
> +                reg = this->getRegister(llvmValues, 4*msg+elemID);
> +
>                tupleData.push_back(reg);
>              }
>              const ir::Tuple tuple = ctx.arrayTuple(&tupleData[0], 4);
> @@ -2535,6 +2547,9 @@ namespace gbe
>          }
>        } else {
>          for (uint32_t elemID = 0; elemID < elemNum; elemID++) {
> +          if(regTranslator.isUndefConst(llvmValues, elemID))
> +            continue;
> +
>            const ir::Register reg = this->getRegister(llvmValues, elemID);
>            ir::Register addr;
>            if (elemID == 0)
> -- 
> 1.8.1.2
> 
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet


More information about the Beignet mailing list