[Beignet] [PATCH 0/2] gen binary with pci info.

[Zhigang Gong]

Xionghu,

Thanks for the patch. One major comment here is:

Maybe we don't need to put pci id into the binary file. Just put a platform
name may be better. For example, the backend only generate code for
byt/ivb/hsw currently. And each platform may have many variants which
have different PCI IDs but they are compatible at the gen binary level.

Any idea?

On Tue, Jul 08, 2014 at 12:39:05PM +0800, xionghu.luo at intel.com wrote:
> From: LuoXionghu <xionghu.luo at intel.com>
> 
> this patchset depends on the patch 
> "remove lspci, gbe_bin_genenrater would generator llvm binary by default."
> 
> LuoXionghu (2):
>   add pci info in the gen binary code.
>   add utest load_program_from_gen_bin.
> 
>  backend/src/backend/gen_program.cpp   | 34 +++++++++----
>  backend/src/gbe_bin_generater.cpp     |  2 +
>  utests/CMakeLists.txt                 |  3 +-
>  utests/load_program_from_bin.cpp      | 77 -----------------------------
>  utests/load_program_from_bin_file.cpp | 77 +++++++++++++++++++++++++++++
>  utests/load_program_from_gen_bin.cpp  | 93 +++++++++++++++++++++++++++++++++++
>  6 files changed, 199 insertions(+), 87 deletions(-)
>  delete mode 100644 utests/load_program_from_bin.cpp
>  create mode 100644 utests/load_program_from_bin_file.cpp
>  create mode 100644 utests/load_program_from_gen_bin.cpp
> 
> -- 
> 1.8.1.2
> 
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet