[Beignet] [PATCH] GBE: Fix a jump issue in int64 to float conversion

Zhigang Gong zhigang.gong at linux.intel.com
Fri Jun 6 00:17:29 PDT 2014


This patch LGTM, thanks.

> -----Original Message-----
> From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of
> Ruiling Song
> Sent: Friday, June 6, 2014 2:57 PM
> To: beignet at lists.freedesktop.org
> Cc: Ruiling Song
> Subject: [Beignet] [PATCH] GBE: Fix a jump issue in int64 to float
conversion
> 
> The the inactive lanes should use 32, so later jump could jump as desired.
> 
> Signed-off-by: Ruiling Song <ruiling.song at intel.com>
> ---
>  backend/src/backend/gen_context.cpp |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/backend/src/backend/gen_context.cpp
> b/backend/src/backend/gen_context.cpp
> index 7a0a806..e116a2f 100644
> --- a/backend/src/backend/gen_context.cpp
> +++ b/backend/src/backend/gen_context.cpp
> @@ -833,7 +833,7 @@ namespace gbe
>      GenRegister dst_ud = GenRegister::retype(dst, GEN_TYPE_UD);
>      p->push();
>        p->curr.noMask = 1;
> -      p->MOV(exp, GenRegister::immud(-1)); // make sure the inactive lane
> is 1 when check ALL8H/ALL16H condition latter.
> +      p->MOV(exp, GenRegister::immud(32)); // make sure the inactive lane
> is 1 when check ALL8H/ALL16H condition latter.
>      p->pop();
>      p->FBH(exp, high);
>      p->ADD(exp, GenRegister::negate(exp), GenRegister::immud(31));
> //exp = 32 when high == 0
> --
> 1.7.10.4
> 
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet



More information about the Beignet mailing list