[Beignet] [PATCH] GBE: ignoring some debug related intrinsics.

Yang, Rong R rong.r.yang at intel.com
Tue Jun 10 19:24:17 PDT 2014


LGTM, thanks.

-----Original Message-----
From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of Zhigang Gong
Sent: Wednesday, June 11, 2014 9:37 AM
To: Gong, Zhigang
Cc: beignet at lists.freedesktop.org
Subject: Re: [Beignet] [PATCH] GBE: ignoring some debug related intrinsics.

Ping for review.

On Fri, Jun 06, 2014 at 03:36:31PM +0800, Zhigang Gong wrote:
> We don't need to assert the kernel if we met some debug related 
> intrinsics. Just ignore them.
> 
> This patch could make beignet works well with Debug mode clBLAS.
> 
> Signed-off-by: Zhigang Gong <zhigang.gong at intel.com>
> ---
>  backend/src/llvm/llvm_gen_backend.cpp | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/backend/src/llvm/llvm_gen_backend.cpp 
> b/backend/src/llvm/llvm_gen_backend.cpp
> index db9e73c..4215939 100644
> --- a/backend/src/llvm/llvm_gen_backend.cpp
> +++ b/backend/src/llvm/llvm_gen_backend.cpp
> @@ -2188,6 +2188,10 @@ namespace gbe
>              this->newRegister(&I);
>            break;
>  #endif /* LLVM_VERSION_MINOR >= 2 */
> +          case Intrinsic::debugtrap:
> +          case Intrinsic::dbg_value:
> +          case Intrinsic::dbg_declare:
> +          break;
>            default:
>            GBE_ASSERTM(false, "Unsupported intrinsics");
>          }
> @@ -2488,6 +2492,10 @@ namespace gbe
>            case Intrinsic::lifetime_end:
>            break;
>  #endif /* LLVM_VERSION_MINOR >= 2 */
> +          case Intrinsic::debugtrap:
> +          case Intrinsic::dbg_value:
> +          case Intrinsic::dbg_declare:
> +          break;
>            default: NOT_IMPLEMENTED;
>          }
>        } else {
> --
> 1.8.3.2
> 
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet
_______________________________________________
Beignet mailing list
Beignet at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/beignet


More information about the Beignet mailing list