[Beignet] beignet doesnt compile with LLVM 3.6

Zhenyu Wang zhenyuw at linux.intel.com
Mon Nov 3 23:16:18 PST 2014


On 2014.11.03 08:46:41 +0000, Yang, Rong R wrote:
> Yes, some errors is because llvm use std:: unique_ptr as some function’s return
> value instead of the normal ptr, there are some other errors after fix std:: 
> unique_ptr error.
> 
> As we notice that LLVM plan to release LLVM/Clang 3.6 soon, suppose the LLVM
> 3.6 approach to stable now, I am working to support LLVM 3.6 now. Hope could
> finish it soon.
> 

One option is to explicitly say the llvm version that beignet does support
and refuse to go on otherwise, like below one?

From: Zhenyu Wang <zhenyuw at linux.intel.com>
Date: Tue, 4 Nov 2014 15:14:44 +0800
Subject: [PATCH] Explicitly check LLVM version when building

Instead of allowing for failure attemps to build with llvm unstable
version this trys to explicitly tell the llvm version that beignet support.

Signed-off-by: Zhenyu Wang <zhenyuw at linux.intel.com>
---
 CMakeLists.txt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 40cb74c..7059b2b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -94,6 +94,9 @@ set (CMAKE_C_FLAGS_RELEASE        "-O2 -DNDEBUG -DGBE_DEBUG=0")
 # Front end stuff we need
 #INCLUDE(CMake/FindLLVM.cmake)
 Find_Package(LLVM 3.3)
+IF(LLVM_VERSION VERSION_GREATER 3.5)
+  MESSAGE(FATAL_ERROR "Don't support LLVM > 3.5 now.")
+ENDIF(LLVM_VERSION VERSION_GREATER 3.5)
 
 set (CMAKE_SHARED_LINKER_FLAGS "-Wl,--no-undefined ${LLVM_LDFLAGS}")
 
-- 
2.1.1

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/beignet/attachments/20141104/21747eaa/attachment.sig>


More information about the Beignet mailing list