[Beignet] [PATCH 4/4] GBE: a potential bug in instruction scheduling.

[Zhigang Gong]

You are right, ELSE also need to be added.

> -----Original Message-----
> From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of
> Luo, Xionghu
> Sent: Thursday, August 13, 2015 1:25 PM
> To: Gong, Zhigang; beignet at lists.freedesktop.org
> Cc: Gong, Zhigang
> Subject: Re: [Beignet] [PATCH 4/4] GBE: a potential bug in instruction
> scheduling.
> 
> 
> 
> Luo Xionghu
> Best Regards
> 
> -----Original Message-----
> From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of
> Zhigang Gong
> Sent: Thursday, August 13, 2015 10:24 AM
> To: beignet at lists.freedesktop.org
> Cc: Gong, Zhigang
> Subject: [Beignet] [PATCH 4/4] GBE: a potential bug in instruction scheduling.
> 
> ENDIF should be treated as barrier-like instruction in instruction scheduling.
> 
> Signed-off-by: Zhigang Gong <zhigang.gong at intel.com>
> ---
>  backend/src/backend/gen_insn_scheduling.cpp | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/backend/src/backend/gen_insn_scheduling.cpp
> b/backend/src/backend/gen_insn_scheduling.cpp
> index b3b7042..5c55079 100644
> --- a/backend/src/backend/gen_insn_scheduling.cpp
> +++ b/backend/src/backend/gen_insn_scheduling.cpp
> @@ -583,7 +583,10 @@ namespace gbe
>      for (int32_t insnID = 0; insnID < insnNum; ++insnID) {
>        ScheduleDAGNode *node = tracker.insnNodes[insnID];
>        if (node->insn.isBranch() || node->insn.isLabel()
> -          || node->insn.opcode == SEL_OP_EOT || node->insn.opcode ==
> SEL_OP_IF || node->insn.opcode == SEL_OP_WHILE
> +          || node->insn.opcode == SEL_OP_EOT
> +          || node->insn.opcode == SEL_OP_IF
> +          || node->insn.opcode == SEL_OP_ENDIF
> +          || node->insn.opcode == SEL_OP_WHILE
> What about SEL_OP_ELSE instruction?
> 
>            || node->insn.opcode == SEL_OP_READ_ARF
>            || node->insn.opcode == SEL_OP_BARRIER)
>          tracker.makeBarrier(insnID, insnNum);
> --
> 1.9.1
> 
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet