[Beignet] [PATCH 3/4] GBE: remove unnecessary assert

Zhigang Gong zhigang.gong at linux.intel.com
Tue May 12 19:01:05 PDT 2015


LGTM, will push latter. Thanks.

On Thu, Apr 30, 2015 at 11:49:48AM +0800, Ruiling Song wrote:
> Signed-off-by: Ruiling Song <ruiling.song at intel.com>
> ---
>  backend/src/backend/gen7_encoder.cpp | 1 -
>  backend/src/backend/gen8_encoder.cpp | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/backend/src/backend/gen7_encoder.cpp b/backend/src/backend/gen7_encoder.cpp
> index a7d132c..fc358be 100644
> --- a/backend/src/backend/gen7_encoder.cpp
> +++ b/backend/src/backend/gen7_encoder.cpp
> @@ -132,7 +132,6 @@ namespace gbe
>    void Gen7Encoder::setSrc1(GenNativeInstruction *insn, GenRegister reg) {
>      Gen7NativeInstruction *gen7_insn = &insn->gen7_insn;
>      assert(reg.nr < 128);
> -    assert(reg.file != GEN_ARCHITECTURE_REGISTER_FILE || reg.nr == 0);
>  
>      gen7_insn->bits1.da1.src1_reg_file = reg.file;
>      gen7_insn->bits1.da1.src1_reg_type = reg.type;
> diff --git a/backend/src/backend/gen8_encoder.cpp b/backend/src/backend/gen8_encoder.cpp
> index 48419aa..f02a2ca 100644
> --- a/backend/src/backend/gen8_encoder.cpp
> +++ b/backend/src/backend/gen8_encoder.cpp
> @@ -384,7 +384,6 @@ namespace gbe
>    void Gen8Encoder::setSrc1(GenNativeInstruction *insn, GenRegister reg) {
>      Gen8NativeInstruction *gen8_insn = &insn->gen8_insn;
>      assert(reg.nr < 128);
> -    assert(reg.file != GEN_ARCHITECTURE_REGISTER_FILE || reg.nr == 0);
>  
>      gen8_insn->bits2.da1.src1_reg_file = reg.file;
>      gen8_insn->bits2.da1.src1_reg_type = reg.type;
> -- 
> 2.3.6
> 
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet


More information about the Beignet mailing list