[Beignet] [PATCH] correct the src output of alu3 when OCL_OUTPUT_ASM=1

Song, Ruiling ruiling.song at intel.com
Thu May 14 01:08:14 PDT 2015


LGTM

> -----Original Message-----
> From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of
> Guo, Yejun
> Sent: Wednesday, May 13, 2015 4:32 PM
> To: Guo, Yejun; beignet at lists.freedesktop.org
> Subject: Re: [Beignet] [PATCH] correct the src output of alu3 when
> OCL_OUTPUT_ASM=1
> 
> Ping for review, thanks.
> 
> -----Original Message-----
> From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of
> Guo Yejun
> Sent: Monday, May 04, 2015 4:47 PM
> To: beignet at lists.freedesktop.org
> Cc: Guo, Yejun
> Subject: [Beignet] [PATCH] correct the src output of alu3 when
> OCL_OUTPUT_ASM=1
> 
> Signed-off-by: Guo Yejun <yejun.guo at intel.com>
> ---
>  backend/src/backend/gen/gen_mesa_disasm.c | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/backend/src/backend/gen/gen_mesa_disasm.c
> b/backend/src/backend/gen/gen_mesa_disasm.c
> index f8d89e0..705f5e2 100644
> --- a/backend/src/backend/gen/gen_mesa_disasm.c
> +++ b/backend/src/backend/gen/gen_mesa_disasm.c
> @@ -831,7 +831,10 @@ static int src0_3src(FILE *file, const void* inst)
>      return 0;
>    if (GEN_BITS_FIELD(inst, bits2.da3src.src0_subreg_nr))
>      format(file, ".%d", GEN_BITS_FIELD(inst,
> bits2.da3src.src0_subreg_nr));
> -  string(file, "<4,1,1>");
> +  if (GEN_BITS_FIELD(inst, bits2.da3src.src0_rep_ctrl))
> +    string(file, "<0,1,0>");
> +  else
> +    string(file, "<8,8,1>");
>    err |= control(file, "src da16 reg type", reg_encoding,
>                   GEN_TYPE_F, NULL);
>    /*
> @@ -876,7 +879,10 @@ static int src1_3src(FILE *file, const void* inst)
>      return 0;
>    if (src1_subreg_nr)
>      format(file, ".%d", src1_subreg_nr);
> -  string(file, "<4,1,1>");
> +  if (GEN_BITS_FIELD(inst, bits2.da3src.src1_rep_ctrl))
> +    string(file, "<0,1,0>");
> +  else
> +    string(file, "<8,8,1>");
>    err |= control(file, "src da16 reg type", reg_encoding,
>                   GEN_TYPE_F, NULL);
>    /*
> @@ -918,7 +924,10 @@ static int src2_3src(FILE *file, const void* inst)
>      return 0;
>    if (GEN_BITS_FIELD(inst, bits3.da3src.src2_subreg_nr))
>      format(file, ".%d", GEN_BITS_FIELD(inst,
> bits3.da3src.src2_subreg_nr));
> -  string(file, "<4,1,1>");
> +  if (GEN_BITS_FIELD(inst, bits3.da3src.src2_rep_ctrl))
> +    string(file, "<0,1,0>");
> +  else
> +    string(file, "<8,8,1>");
>    err |= control(file, "src da16 reg type", reg_encoding,
>                   GEN_TYPE_F, NULL);
>    /*
> --
> 1.9.1
> 
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet


More information about the Beignet mailing list