[Beignet] [PATCH] Fix sizing error for bitfield

Yang, Rong R rong.r.yang at intel.com
Wed Nov 18 23:45:05 PST 2015


Push, thanks. BTW, please add Signed-off-by next time, it will add automatic when format-patch with option -s.

> -----Original Message-----
> From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of
> Song, Ruiling
> Sent: Thursday, November 19, 2015 11:12
> To: Giuseppe Bilotta; beignet at lists.freedesktop.org
> Subject: Re: [Beignet] [PATCH] Fix sizing error for bitfield
> 
> > -----Original Message-----
> > From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf
> > Of Giuseppe Bilotta
> > Sent: Thursday, November 19, 2015 3:52 AM
> > To: beignet at lists.freedesktop.org
> > Cc: Giuseppe Bilotta <giuseppe.bilotta at gmail.com>
> > Subject: [Beignet] [PATCH] Fix sizing error for bitfield
> >
> > The mergeable field was define as an uint32_t, but MAX_SRC_NUM is now
> > 40, so we need at least an uint64_t.
> > ---
> >  backend/src/backend/gen_insn_selection.cpp | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/backend/src/backend/gen_insn_selection.cpp
> > b/backend/src/backend/gen_insn_selection.cpp
> > index 84cfb6d..e1cf6f7 100644
> > --- a/backend/src/backend/gen_insn_selection.cpp
> > +++ b/backend/src/backend/gen_insn_selection.cpp
> > @@ -279,7 +279,7 @@ namespace gbe
> >      /*! Instruction that needs to be matched */
> >      const ir::Instruction &insn;
> >      /*! When sources have been overwritten, a child insn cannot be
> > merged */
> > -    uint32_t mergeable:ir::Instruction::MAX_SRC_NUM;
> > +    uint64_t mergeable:ir::Instruction::MAX_SRC_NUM;
> >      /*! Number of children we have in the pattern */
> >      uint32_t childNum:7;
> >      /*! A root must be generated, no matter what */
> > --
> > 2.6.0.rc2.233.g6dd8a9a.dirty
> 
> Hi Giuseppe,
> 
> Thanks for the fix, and the patch LGTM.
> 
> Ruiling
> >
> > _______________________________________________
> > Beignet mailing list
> > Beignet at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/beignet
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet


More information about the Beignet mailing list