<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 14 (filtered medium)"> <style></style> </head> <body lang="ZH-CN" link="blue" vlink="purple"> <div class="WordSection1"> <p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1F497D">[Ruling] Yes, I will refine the code, it is really bad naming. I will make it clear and remove the OWord block read/write.<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" style="color:#500050"> And maybe you can get some hint that why you failed to use the OBlock read/write to implement the spill/unspill.</span><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1F497D">[Ruiling] No, the failure is not related with OBlock read/write. </span><span lang="EN-US" style="color:#500050">OBlock read/write</span><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1F497D"> also works. The failure have already been fixed by previous patch “Fix a bug in stack calculation”. Thanks for your various comments.<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p> <p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> zhigang gong [mailto:zhigang.gong@gmail.com] <br> <b>Sent:</b> Wednesday, August 07, 2013 2:14 PM<br> <b>To:</b> Song, Ruiling<br> <b>Cc:</b> beignet@lists.freedesktop.org<br> <b>Subject:</b> Re: [Beignet] [PATCH 1/2] enable scratch memory allocation and read/write<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p> <div> <p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p> <div> <div> <p class="MsoNormal"><span lang="EN-US">On Wed, Aug 7, 2013 at 1:44 PM, Song, Ruiling <<a href="mailto:ruiling.song@intel.com" target="_blank">ruiling.song@intel.com</a>> wrote:<o:p></o:p></span></p> <div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><span lang="EN-US"><o:p></o:p></span></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><span lang="EN-US"><o:p></o:p></span></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> zhigang gong [mailto:<a href="mailto:zhigang.gong@gmail.com" target="_blank">zhigang.gong@gmail.com</a>] <br> <b>Sent:</b> Wednesday, August 07, 2013 1:04 PM<br> <b>To:</b> Song, Ruiling<br> <b>Cc:</b> <a href="mailto:beignet@lists.freedesktop.org" target="_blank">beignet@lists.freedesktop.org</a><br> <b>Subject:</b> Re: [Beignet] [PATCH 1/2] enable scratch memory allocation and read/write</span><span lang="EN-US"><o:p></o:p></span></p> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US"> <o:p></o:p></span></p> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US">My suggestion here is to seprate the scratch OBlock read/write out. And submit the<o:p></o:p></span></p> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US">Dword Read/Write part firstly, as OBlock read/write is not used right now, Right?<o:p></o:p></span></p> </div> </div> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;margin-bottom:12.0pt"><span lang="EN-US" style="color:#1F497D">[Ruiling] In fact, I first use OBlock Read/Write for spill implementation. As I met some failure, so, I also implement scratch HBlock. I call it HBlock as it always read multiples of HWord. There are two modes of scratch RW, but I only enable DWORD </span><span lang="EN-US"><o:p></o:p></span></p> </div> </div> </div> <div> <p class="MsoNormal"><span lang="EN-US"> I think you should use Dword to keep align with the spec. It has reason that although it read data start from Hword alignment,<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US"> but it only use the part of the data according to the data type. For example, if the data type is Dword then it only put the first 8 Dword<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US"> of data to the destination registers.<o:p></o:p></span></p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"> <div> <div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;margin-bottom:12.0pt"><span lang="EN-US" style="color:#1F497D">mode. That is the HBlock in the patch. If you have concern about the oword block rw, I can remove OBlock RW logic.</span><span lang="EN-US"><o:p></o:p></span></p> </div> </div> </div> </blockquote> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"> <div> <div> <div> <div> <div> <div> <div> <div> <div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0cm;margin-bottom:5.0pt"> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US">+ void GenEncoder::SCRATCH_READ_HWORD(GenRegister dst, GenRegister src, uint32_t offset, uint32_t size, uint32_t dst_num)<o:p></o:p></span></p> </div> </blockquote> </div> </div> <div> <div> <div> <div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0cm;margin-bottom:5.0pt"> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US">+ {<br> + assert(dst_num == 1 || dst_num ==2);<br> + uint32_t block_size = dst_num == 1 ? GEN_SCRATCH_BLOCK_SIZE_1 : GEN_SCRATCH_BLOCK_SIZE_2;<br> + GenInstruction *insn = this->next(GEN_OPCODE_SEND);<br> + this->setHeader(insn);<br> + this->setDst(insn, dst);<br> + this->setSrc0(insn, src);<br> + this->setSrc1(insn, GenRegister::immud(0));<br> + // here dst_num is the register that will be write-back: in terms of 32byte register<br> + setScratchMessage(this, insn, offset, block_size, GEN_SCRATCH_DATA_DWORD, GEN_SCRATCH_READ, 1, dst_num);<br> + }<br> +<br> + void GenEncoder::SCRATCH_WRITE_OWORD(GenRegister msg, uint32_t size, uint32_t src_num)<br> + {<br> + GenInstruction *insn = this->next(GEN_OPCODE_SEND);<br> + this->setHeader(insn);<br> + this->setDst(insn, GenRegister::retype(GenRegister::null(), GEN_TYPE_UD));<br> + this->setSrc0(insn, msg);<br> + this->setSrc1(insn, GenRegister::immud(0));<br> + // here src_num means registers that will be write out: in terms of 32byte register number<br> + setOBlockRW(this, insn, 255, size/16, GEN_OBLOCK_WRITE, src_num+1, 0);<br> + }<o:p></o:p></span></p> </blockquote> </div> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US"> I'm confused here, you prepared a message header for Scratch OWord read/write, but then you send a </span><span lang="EN-US" style="font-size:10.0pt;font-family:"Arial","sans-serif"">OWord Block Read</span><span lang="EN-US"><o:p></o:p></span></p> </div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US" style="font-size:10.0pt;font-family:"Arial","sans-serif""> message. I don't think it's going to work as desired. You can check the "OWord Block Read/Write" in the spec, you can find</span><span lang="EN-US"><o:p></o:p></span></p> </div> </div> </div> <div> <div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US" style="font-size:10.0pt;font-family:"Arial","sans-serif""> a restriction there:</span><span lang="EN-US"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US" style="font-size:10.0pt;font-family:"Arial","sans-serif""> the only surface type allowed is SURFTYPE_BUFFER.</span><span lang="EN-US"><o:p></o:p></span></p> </div> </div> </div> <div> <div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US" style="font-size:10.0pt;font-family:"Arial","sans-serif""> And here, the surface is a scratch buffer.</span><span lang="EN-US"><o:p></o:p></span></p> </div> </div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1F497D">[Ruiling] scratch buffer is stateless buffer, i.e. </span><span lang="EN-US" style="font-size:10.0pt;font-family:"Arial","sans-serif"">SURFTYPE_BUFFER. It is more preferred to call “OWord block read/write” instead of “scratch OWord block read/write”. This is not what written as oword mode under scratch memory read/write.</span><span lang="EN-US"><o:p></o:p></span></p> </div> </div> </div> </div> </div> </div> </div> </blockquote> <div> <p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US"> You are right, the scratch buffer is one type of SURFTYPE_BUFFER and can be accessed by OWord block read/write.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US"> What confused me is you are using <span style="color:#500050">SCRATCH_WRITE_OWORD as the function name. You know there are real</span><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="color:#500050"> Scratch Block Read/Write for OWord which is quite different from this OWord Bloc read. Right? They have different</span><span lang="EN-US"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="color:#500050"> message descriptor and different payload/writeback message.</span><span lang="EN-US"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="color:#500050"> Ben had implemented the OBlock read/write extension before. And for some reason he removed those implementations.</span><span lang="EN-US"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="color:#500050"> If you really want to use OBlock read/write here, it may worth to find what Ben already implemented before and see what we</span><span lang="EN-US"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="color:#500050"> can reuse here. And maybe you can get some hint that why you failed to use the OBlock read/write to implement the spill/unspill.</span><span lang="EN-US"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="color:#500050"> Anyway, use scratch_write/read_oword is quite misleading here, and should be corrected. What do you think?</span><span lang="EN-US"><o:p></o:p></span></p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"> <div> <div> <div> <div> <div> <div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US" style="color:#500050"> </span><span lang="EN-US"><o:p></o:p></span></p> </div> </div> </div> </div> </div> </div> </div> </blockquote> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"> <div> <div> <div> <div> <div> <div> <div> <div> <div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US"> I'm thinking of is there a way to test the scratch read/write directly? Maybe it's not so straightforward as it's only<o:p></o:p></span></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US"> used when spill/unspill occurs. And if a kernel triggers spill/unspill, it means the kernel is not very simple and can't<o:p></o:p></span></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US"> be a proper unit test case for scratch read/write. Any good idea?<o:p></o:p></span></p> </div> </div> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US" style="color:#1F497D">[Ruiling] this is also a problem I met. At last I only can manually call spillReg() to select one virtual register I want, so, I don</span><span style="font-family:SimSun;color:#1F497D">’</span><span lang="EN-US" style="color:#1F497D">t have to face a complex kernel. But I don</span><span style="font-family:SimSun;color:#1F497D">’</span><span lang="EN-US" style="color:#1F497D">t have good way of verifying scratch RW.</span><span lang="EN-US"><o:p></o:p></span></p> </div> <div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US" style="color:#888888"> - Zhigang</span><span lang="EN-US"><o:p></o:p></span></p> </div> <div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0cm;margin-bottom:5.0pt"> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US" style="color:#888888">--<br> 1.7.9.5<br> <br> _______________________________________________<br> Beignet mailing list<br> <a href="mailto:Beignet@lists.freedesktop.org" target="_blank">Beignet@lists.freedesktop.org</a><br> <a href="http://lists.freedesktop.org/mailman/listinfo/beignet" target="_blank">http://lists.freedesktop.org/mailman/listinfo/beignet</a></span><span lang="EN-US"><o:p></o:p></span></p> </blockquote> </div> </div> </div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US"> <o:p></o:p></span></p> </div> </div> </div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US"> <o:p></o:p></span></p> </div> </div> </div> </blockquote> </div> <p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p> </div> </div> </div> </body> </html>