<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 14 (filtered medium)"> <style></style> </head> <body lang="ZH-CN" link="blue" vlink="purple"> <div class="WordSection1"> When I do a spill, I directly construct a physical register, see below:<o:p></o:p> spill->src(0) =GenRegister(GEN_GENERAL_REGISTER_FILE, dstStart + dstID, 0,<o:p></o:p> selReg.type, selReg.vstride, selReg.width, selReg.hstride);<o:p></o:p> and also allocate one physical register from reserved register pool, change the spilled virtual register to physical register:<o:p></o:p> dst.physical =1; dst.nr = dstStart+dstID; dst.subnr = 0;<o:p></o:p> so, in later emit code, when they call ra->genReg(), I will directly return the physical register; see GenRegAllocator::Opaque::genReg()<o:p></o:p> <o:p> </o:p> From: beignet-bounces+ruiling.song=intel.com@lists.freedesktop.org [mailto:beignet-bounces+ruiling.song=intel.com@lists.freedesktop.org] On Behalf Of zhigang gong Sent: Friday, August 09, 2013 4:29 PM To: Song, Ruiling Cc: beignet@lists.freedesktop.org Subject: Re: [Beignet] [PATCH 2/2] Skip spill/unspill instruction when trying to do spill.<o:p></o:p> <o:p> </o:p> <div> <div> Could you tell something more about how could a spilledReg be a physical register?<o:p></o:p> </div> <div> This is not very clear for me. If a virtual register is to be spilled, then it will<o:p></o:p> </div> <div> always be a virtual register, and will be unspilled when it is used. When it may<o:p></o:p> </div> <div> become a physical register?<o:p></o:p> </div> <div> <o:p> </o:p> </div> </div> <div> <o:p> </o:p> <div> On Fri, Aug 9, 2013 at 1:23 PM, Ruiling Song <<a href="mailto:ruiling.song@intel.com" target="_blank">ruiling.song@intel.com</a>> wrote:<o:p></o:p> We can only spill virtual registers, should skip physical register. This fix random failure of compiler_box_blur when do spilling. Signed-off-by: Ruiling Song <<a href="mailto:ruiling.song@intel.com">ruiling.song@intel.com</a>> --- backend/src/backend/gen_insn_selection.cpp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/backend/src/backend/gen_insn_selection.cpp b/backend/src/backend/gen_insn_selection.cpp index 3610051..5cafa98 100644 --- a/backend/src/backend/gen_insn_selection.cpp +++ b/backend/src/backend/gen_insn_selection.cpp @@ -628,12 +628,15 @@ namespace gbe for (auto &block : blockList) for (auto &insn : block.insnList) { + // spill / unspill insn should be skipped when do spilling + if(insn.opcode == SEL_OP_SPILL_REG || insn.opcode == SEL_OP_UNSPILL_REG) continue; + const uint32_t srcNum = insn.srcNum, dstNum = insn.dstNum; for (uint32_t srcID = 0; srcID < srcNum; ++srcID) { const GenRegister selReg = insn.src(srcID); const ir::Register reg = selReg.reg(); - if(selReg.file == GEN_GENERAL_REGISTER_FILE && reg == spilledReg) { + if(reg == spilledReg && selReg.file == GEN_GENERAL_REGISTER_FILE && selReg.physical == 0) { GBE_ASSERT(srcID < 5); SelectionInstruction *unspill = this->create(SEL_OP_UNSPILL_REG, 1, 0); unspill->state = GenInstructionState(simdWidth); @@ -652,7 +655,7 @@ namespace gbe for (uint32_t dstID = 0; dstID < dstNum; ++dstID) { const GenRegister selReg = insn.dst(dstID); const ir::Register reg = selReg.reg(); - if(selReg.file == GEN_GENERAL_REGISTER_FILE && reg == spilledReg) { + if(reg == spilledReg && selReg.file == GEN_GENERAL_REGISTER_FILE && selReg.physical == 0) { GBE_ASSERT(dstID < 5); SelectionInstruction *spill = this->create(SEL_OP_SPILL_REG, 0, 1); spill->state = GenInstructionState(simdWidth); -- 1.7.9.5 _______________________________________________ Beignet mailing list <a href="mailto:Beignet@lists.freedesktop.org">Beignet@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/beignet" target="_blank">http://lists.freedesktop.org/mailman/listinfo/beignet</a><o:p></o:p> </div> <o:p> </o:p> </div> </div> </body> </html>