<div dir="ltr"><div>~/workspace/cpp/beignet_opencl_1_2/build$ llvm-as --version</div><div>LLVM (<a href="http://llvm.org/">http://llvm.org/</a>):</div><div>а LLVM version 3.3</div><div>аа</div><div>а Optimized build.</div> <div>а Built Aug 29 2013 (07:58:28).</div><div>а Default target: x86_64-pc-linux-gnu</div><div>а Host CPU: core-avx-i</div><div><br></div><div><br></div><div>previous warnings still exists and without your patch compiles failed with this :а<br> <br><div>In file included from beignet_opencl_1_2/src/cl_khr_icd.c:18:0:</div><div>/usr/include/ocl_icd.h:744:5: error: unknown type name Сcl_device_partition_propertyТ</div><div>а а аconst cl_device_partition_property * /* properties */,</div> <div>а а а^</div><div>/usr/include/ocl_icd.h:748:5: error: expected С:Т, С,Т, С;Т, С}Т or С__attribute__Т before СCL_API_SUFFIX__VERSION_1_2Т</div><div>а а) CL_API_SUFFIX__VERSION_1_2;</div><div>а а а^</div><div>make[2]: *** [src/CMakeFiles/cl.dir/cl_khr_icd.c.o] Error 1</div> <div>make[2]: *** Waiting for unfinished jobs....</div><div>make[1]: *** [src/CMakeFiles/cl.dir/all] Error 2</div><div>make: *** [all] Error 2</div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote"> 2014/1/9 Zhigang Gong <span dir="ltr"><<a href="mailto:zhigang.gong@linux.intel.com" target="_blank">zhigang.gong@linux.intel.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div class="im">On Wed, Jan 08, 2014 at 08:39:28PM +0100, Robert Jobbagy wrote:<br> > Thanks your help.<br> ><br> > First of all I use this llvm version :<br> > <a href="https://launchpad.net/ubuntu/saucy/+source/llvm-toolchain-3.3" target="_blank">https://launchpad.net/ubuntu/saucy/+source/llvm-toolchain-3.3</a><br> ><br> > I update to HEAD and I gave two errors :<br> ><br> > first :<br> ><br> > [ а0%] Generating ocl_barrier.ll.bc<br> > llvm-as:<br> > /home/evil85/workspace/cpp/beignet_opencl_1_2/backend/src/ocl_barrier.ll:13:43:<br> > error: expected '{' in function body<br> > define void @barrier(i32 %flags) nounwind noduplicate alwaysinline {<br> <br> </div>"noduplicate" can't be removed here. It's weird that llvm-as 3.3 should support noduplicate<br> attribute. Could you double check the llvm-as version by execute:<br> llvm-as --version<br> manually?<br> <div><div class="h5"><br> > а а а а а а а а а а а а а а а а а а а а а ^<br> > make[2]: *** [backend/src/ocl_barrier.ll.bc] Error 1<br> > make[1]: *** [backend/src/CMakeFiles/beignet.bc.dir/all] Error 2<br> ><br> ><br> > This modification is fixed it :<br> ><br> > --- a/backend/src/ocl_barrier.ll<br> > +++ b/backend/src/ocl_barrier.ll<br> > @@ -10,7 +10,7 @@ declare void @__gen_ocl_barrier_local() nounwind<br> > alwaysinline<br> > аdeclare void @__gen_ocl_barrier_global() nounwind alwaysinline<br> > аdeclare void @__gen_ocl_barrier_local_and_global() nounwind alwaysinline<br> ><br> > -define void @barrier(i32 %flags) nounwind noduplicate alwaysinline {<br> > +define void @barrier(i32 %flags) nounwind alwaysinline {<br> > а а%1 = icmp eq i32 %flags, 3<br> > а аbr i1 %1, label %barrier_local_global, label %barrier_local_check<br> ><br> ><br> > second :<br> ><br> > In file included from<br> > /home/evil85/workspace/cpp/beignet_opencl_1_2/src/cl_khr_icd.c:18:0:<br> > /usr/include/ocl_icd.h:744:5: error: unknown type name<br> > Сcl_device_partition_propertyТ<br> > а а аconst cl_device_partition_property * /* properties */,<br> > а а а^<br> > /usr/include/ocl_icd.h:748:5: error: expected С:Т, С,Т, С;Т, С}Т or<br> > С__attribute__Т before СCL_API_SUFFIX__VERSION_1_2Т<br> > а а) CL_API_SUFFIX__VERSION_1_2;<br> > а а а^<br> > make[2]: *** [src/CMakeFiles/cl.dir/cl_khr_icd.c.o] Error 1<br> > make[1]: *** [src/CMakeFiles/cl.dir/all] Error 2<br> > make: *** [all] Error 2<br> ><br> ><br> > Solution:<br> ><br> > I applied your CL: back port ICD support to 1.1. branch patch on my 1.2<br> > branch and everything compiled fine :)<br> </div></div>This sympton means it is on the master branch rather the opencl-1.2 branch.<br> <br> If it is opencl-1.2 branch, then it uses those opencl 1.2 header files which<br> should not have this compilation problem. This compilation problem will only<br> be triggerred with opencl 1.1 header file included. And my patch is to fix that<br> with 1.1 header files.<br> <div class="HOEnZb"><div class="h5"><br> ><br> ><br> ><br> > 2014/1/8 Zhigang Gong <<a href="mailto:zhigang.gong@linux.intel.com">zhigang.gong@linux.intel.com</a>><br> ><br> > > I'm using 3.3.1 which works fine on the 1.2 branch. From the warning<br> > > messages<br> > > you gave below, I doubt there maybe some conflict llvm/clang version<br> > > problem<br> > > on your system. You can see the first warning is totally triggerred by the<br> > > llvm<br> > > and clang's header files. If you have a clean 3.3 clang/llvm installation<br> > > in your<br> > > system, that should not happen.<br> > ><br> > > Another issue is that now we only support llvm/clang 3.3 but the cmake<br> > > will find<br> > > some earlier version of llvm. Simon already submitted a patch to fix that.<br> > > I just<br> > > modified it slightly and push it to both master branch and opencl-1.2<br> > > branch.<br> > ><br> > > My suggestion for you is to update to the latest opencl-1.2 branch. And<br> > > make<br> > > sure you have a clean llvm/clang 3.3 installation and try it again.<br> > ><br> > > Thanks for reporting this to us and good luck.<br> > ><br> > > On Tue, Jan 07, 2014 at 06:27:55PM +0100, Robert Jobbagy wrote:<br> > > > Hi,<br> > > ><br> > > > After the update I gave this error :<br> > > ><br> > > > /beignet_opencl_1_2/backend/src/ocl_barrier.ll:9:50: error: expected<br> > > > top-level entity<br> > > > declare void @__gen_ocl_barrier_local() nounwind noduplicate alwaysinline<br> > > > а а а а а а а а а а а а а а а а а а а а а а а а а^<br> > > > make[2]: *** [backend/src/ocl_barrier.ll.bc] Error 1<br> > > > make[1]: *** [backend/src/CMakeFiles/beignet.bc.dir/all] Error 2<br> > > > make[1]: *** Waiting for unfinished jobs....<br> > > ><br> > > > I used llvm 3.3-5ubuntu4<br> > > ><br> > > > workaround:<br> > > > I removed all noduplicate marker from declares and defines<br> > > ><br> > > > I saw these warnings too:<br> > > ><br> > > > In file included from<br> > > > /usr/lib/llvm-3.3/include/clang/Basic/VersionTuple.h:19:0,<br> > > > а а а а а а а а аfrom<br> > > > /usr/lib/llvm-3.3/include/clang/Basic/ObjCRuntime.h:18,<br> > > > а а а а а а а а аfrom<br> > > > /usr/lib/llvm-3.3/include/clang/Basic/LangOptions.h:20,<br> > > > а а а а а а а а аfrom<br> > > > /usr/lib/llvm-3.3/include/clang/Frontend/FrontendAction.h:22,<br> > > > а а а а а а а а аfrom<br> > > > /usr/lib/llvm-3.3/include/clang/CodeGen/CodeGenAction.h:13,<br> > > > а а а а а а а а аfrom<br> > > ><br> > > /home/evil85/workspace/cpp/beignet_opencl_1_2/backend/src/backend/program.cpp:56:<br> > > > /usr/lib/llvm-3.3/include/llvm/ADT/Optional.h: In instantiation of СT*<br> > > > llvm::Optional<T>::getPointer() [with T = unsigned int]Т:<br> > > > /usr/lib/llvm-3.3/include/llvm/ADT/Optional.h:123:76: а required from СT&<br> > > > llvm::Optional<T>::operator*() [with T = unsigned int]Т<br> > > > /usr/lib/llvm-3.3/include/llvm/ADT/Optional.h:51:7: а required from<br> > > > Сllvm::Optional<T>::Optional(llvm::Optional<T>&&) [with T = unsigned<br> > > int]Т<br> > > > /usr/lib/llvm-3.3/include/clang/Basic/VersionTuple.h:60:14: а required<br> > > from<br> > > > here<br> > > > /usr/lib/llvm-3.3/include/llvm/ADT/Optional.h:114:79: warning:<br> > > > dereferencing type-punned pointer will break strict-aliasing rules<br> > > > [-Wstrict-aliasing]<br> > > > /usr/lib/llvm-3.3/include/llvm/ADT/Optional.h: In instantiation of СT*<br> > > > llvm::Optional<T>::getPointer() [with T = bool]Т:<br> > > > /usr/lib/llvm-3.3/include/llvm/ADT/Optional.h:123:76: а required from СT&<br> > > > llvm::Optional<T>::operator*() [with T = bool]Т<br> > > > /usr/lib/llvm-3.3/include/llvm/ADT/Optional.h:104:7: а required from<br> > > Сvoid<br> > > > llvm::Optional<T>::reset() [with T = bool]Т<br> > > > /usr/lib/llvm-3.3/include/llvm/ADT/Optional.h:110:5: а required from<br> > > > Сllvm::Optional<T>::~Optional() [with T = bool]Т<br> > > ><br> > > /usr/lib/llvm-3.3/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:397:27:<br> > > > а required from here<br> > > > /usr/lib/llvm-3.3/include/llvm/ADT/Optional.h:114:79: warning:<br> > > > dereferencing type-punned pointer will break strict-aliasing rules<br> > > > [-Wstrict-aliasing]<br> > > ><br> > > ><br> > > /home/evil85/workspace/cpp/beignet_opencl_1_2/backend/src/backend/program.cpp:652:<br> > > > warning: the use of `tmpnam_r' is dangerous, better use `mkstemp'<br> > > ><br> > > ><br> > > > I made something wrong ? Previous version (2013-12-05) compiled fine.<br> > > ><br> > > ><br> > > ><br> > > ><br> > > > --<br> > > > Best Regards,<br> > > ><br> > > > Robert<br> > ><br> > > > _______________________________________________<br> > > > Beignet mailing list<br> > > > <a href="mailto:Beignet@lists.freedesktop.org">Beignet@lists.freedesktop.org</a><br> > > > <a href="http://lists.freedesktop.org/mailman/listinfo/beignet" target="_blank">http://lists.freedesktop.org/mailman/listinfo/beignet</a><br> > ><br> > ><br> ><br> ><br> > --<br> > Best Regards,<br> ><br> > Robert<br> </div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Best Regards,<br><br>Robert </div>