<div dir="ltr">opencl-1.2 branch HEAD is compiled fine, but when I ran utest I saw this warning : <div>libEGL warning: failed to create a pipe screen for i965</div><div> </div></div><div class="gmail_extra"> <div class="gmail_quote">2014/1/9 Zhigang Gong <<a href="mailto:zhigang.gong@linux.intel.com" target="_blank">zhigang.gong@linux.intel.com</a>> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> This is a pure llvm related issue. The error messages you gave should be simply from the following command: llvm-as -o ocl_barrier.ll.bc ocl_barrier.ll. <div class="HOEnZb"><div class="h5"> On Thu, Jan 09, 2014 at 10:21:45AM +0100, Robert Jobbagy wrote: > and you use this mesa version 92e6260c1960f78692417433206c38170ec1a625 for > compile ? > > > 2014/1/9 Yang, Rong R <<a href="mailto:rong.r.yang@intel.com">rong.r.yang@intel.com</a>> > > > I have tried the ubutun 13.10's released llvm & clang 3.3 package, don't > > have this error. The llvm-as --version is: > > LLVM (<a href="http://llvm.org/" target="_blank">http://llvm.org/</a>): > > LLVM version 3.3 > > > > Optimized build. > > Built Aug 29 2013 (08:00:45). > > Default target: i386-pc-linux-gnu > > Host CPU: core-avx-i > > > > > > -----Original Message----- > > From: <a href="mailto:beignet-bounces@lists.freedesktop.org">beignet-bounces@lists.freedesktop.org</a> [mailto: > > <a href="mailto:beignet-bounces@lists.freedesktop.org">beignet-bounces@lists.freedesktop.org</a>] On Behalf Of Zhigang Gong > > Sent: Thursday, January 09, 2014 1:43 PM > > To: Robert Jobbagy > > Cc: <a href="mailto:beignet@lists.freedesktop.org">beignet@lists.freedesktop.org</a> > > Subject: Re: [Beignet] opencl-1.2 branch head compile error and warnings > > > > On Thu, Jan 09, 2014 at 06:56:13AM +0100, Robert Jobbagy wrote: > > > ~/workspace/cpp/beignet_opencl_1_2/build$ llvm-as --version LLVM > > > (<a href="http://llvm.org/" target="_blank">http://llvm.org/</a>): > > > LLVM version 3.3 > > > > > > Optimized build. > > > Built Aug 29 2013 (07:58:28). > > > Default target: x86_64-pc-linux-gnu > > > Host CPU: core-avx-i > > The version seems ok. I will try to find the same llvm version as yours to > > see is there anything wrong. > > > > > > > > > > > previous warnings still exists and without your patch compiles failed > > > with this : > > > > > > In file included from beignet_opencl_1_2/src/cl_khr_icd.c:18:0: > > > /usr/include/ocl_icd.h:744:5: error: unknown type name > > > ‘cl_device_partition_property’ > > > const cl_device_partition_property * /* properties */, > > > ^ > > > /usr/include/ocl_icd.h:748:5: error: expected ‘:’, ‘,’, ‘;’, ‘}’ or > > > ‘__attribute__’ before ‘CL_API_SUFFIX__VERSION_1_2’ > > > ) CL_API_SUFFIX__VERSION_1_2; > > > ^ > > > make[2]: *** [src/CMakeFiles/cl.dir/cl_khr_icd.c.o] Error 1 > > > make[2]: *** Waiting for unfinished jobs.... > > > make[1]: *** [src/CMakeFiles/cl.dir/all] Error 2 > > > make: *** [all] Error 2 > > Could you show the top two commit on your working directory? Just copy > > paste the output of git log. > > > > BTW, did you make a clean build? > > #git clean -x -f -d > > #mkdir build > > #cd build > > #cmake .. > > #make > > > > > > > > > > > > > > 2014/1/9 Zhigang Gong <<a href="mailto:zhigang.gong@linux.intel.com">zhigang.gong@linux.intel.com</a>> > > > > > > > On Wed, Jan 08, 2014 at 08:39:28PM +0100, Robert Jobbagy wrote: > > > > > Thanks your help. > > > > > > > > > > First of all I use this llvm version : > > > > > <a href="https://launchpad.net/ubuntu/saucy/+source/llvm-toolchain-3.3" target="_blank">https://launchpad.net/ubuntu/saucy/+source/llvm-toolchain-3.3</a> > > > > > > > > > > I update to HEAD and I gave two errors : > > > > > > > > > > first : > > > > > > > > > > [ 0%] Generating ocl_barrier.ll.bc > > > > > llvm-as: > > > > > > > > > > > /home/evil85/workspace/cpp/beignet_opencl_1_2/backend/src/ocl_barrier.ll:13:43: > > > > > error: expected '{' in function body define void @barrier(i32 > > > > > %flags) nounwind noduplicate alwaysinline { > > > > > > > > "noduplicate" can't be removed here. It's weird that llvm-as 3.3 > > > > should support noduplicate attribute. Could you double check the > > > > llvm-as version by execute: > > > > llvm-as --version > > > > manually? > > > > > > > > > ^ > > > > > make[2]: *** [backend/src/ocl_barrier.ll.bc] Error 1 > > > > > make[1]: *** [backend/src/CMakeFiles/beignet.bc.dir/all] Error 2 > > > > > > > > > > > > > > > This modification is fixed it : > > > > > > > > > > --- a/backend/src/ocl_barrier.ll > > > > > +++ b/backend/src/ocl_barrier.ll > > > > > @@ -10,7 +10,7 @@ declare void @__gen_ocl_barrier_local() nounwind > > > > > alwaysinline declare void @__gen_ocl_barrier_global() nounwind > > > > > alwaysinline declare void @__gen_ocl_barrier_local_and_global() > > > > > nounwind alwaysinline > > > > > > > > > > -define void @barrier(i32 %flags) nounwind noduplicate > > > > > alwaysinline { > > > > > +define void @barrier(i32 %flags) nounwind alwaysinline { > > > > > %1 = icmp eq i32 %flags, 3 > > > > > br i1 %1, label %barrier_local_global, label > > > > > %barrier_local_check > > > > > > > > > > > > > > > second : > > > > > > > > > > In file included from > > > > > /home/evil85/workspace/cpp/beignet_opencl_1_2/src/cl_khr_icd.c:18:0: > > > > > /usr/include/ocl_icd.h:744:5: error: unknown type name > > > > > ‘cl_device_partition_property’ > > > > > const cl_device_partition_property * /* properties */, > > > > > ^ > > > > > /usr/include/ocl_icd.h:748:5: error: expected ‘:’, ‘,’, ‘;’, ‘}’ > > > > > or ‘__attribute__’ before ‘CL_API_SUFFIX__VERSION_1_2’ > > > > > ) CL_API_SUFFIX__VERSION_1_2; > > > > > ^ > > > > > make[2]: *** [src/CMakeFiles/cl.dir/cl_khr_icd.c.o] Error 1 > > > > > make[1]: *** [src/CMakeFiles/cl.dir/all] Error 2 > > > > > make: *** [all] Error 2 > > > > > > > > > > > > > > > Solution: > > > > > > > > > > I applied your CL: back port ICD support to 1.1. branch patch on > > > > > my 1.2 branch and everything compiled fine :) > > > > This sympton means it is on the master branch rather the opencl-1.2 > > branch. > > > > > > > > If it is opencl-1.2 branch, then it uses those opencl 1.2 header > > > > files which should not have this compilation problem. This > > > > compilation problem will only be triggerred with opencl 1.1 header > > > > file included. And my patch is to fix that with 1.1 header files. > > > > > > > > > > > > > > > > > > > > > > > > 2014/1/8 Zhigang Gong <<a href="mailto:zhigang.gong@linux.intel.com">zhigang.gong@linux.intel.com</a>> > > > > > > > > > > > I'm using 3.3.1 which works fine on the 1.2 branch. From the > > > > > > warning messages you gave below, I doubt there maybe some > > > > > > conflict llvm/clang version problem on your system. You can see > > > > > > the first warning is totally triggerred by > > > > the > > > > > > llvm > > > > > > and clang's header files. If you have a clean 3.3 clang/llvm > > > > installation > > > > > > in your > > > > > > system, that should not happen. > > > > > > > > > > > > Another issue is that now we only support llvm/clang 3.3 but the > > > > > > cmake will find some earlier version of llvm. Simon already > > > > > > submitted a patch to fix > > > > that. > > > > > > I just > > > > > > modified it slightly and push it to both master branch and > > > > > > opencl-1.2 branch. > > > > > > > > > > > > My suggestion for you is to update to the latest opencl-1.2 > > > > > > branch. And make sure you have a clean llvm/clang 3.3 > > > > > > installation and try it again. > > > > > > > > > > > > Thanks for reporting this to us and good luck. > > > > > > > > > > > > On Tue, Jan 07, 2014 at 06:27:55PM +0100, Robert Jobbagy wrote: > > > > > > > Hi, > > > > > > > > > > > > > > After the update I gave this error : > > > > > > > > > > > > > > /beignet_opencl_1_2/backend/src/ocl_barrier.ll:9:50: error: > > > > > > > expected top-level entity declare void > > > > > > > @__gen_ocl_barrier_local() nounwind noduplicate > > > > alwaysinline > > > > > > > ^ > > > > > > > make[2]: *** [backend/src/ocl_barrier.ll.bc] Error 1 > > > > > > > make[1]: *** [backend/src/CMakeFiles/beignet.bc.dir/all] Error > > > > > > > 2 > > > > > > > make[1]: *** Waiting for unfinished jobs.... > > > > > > > > > > > > > > I used llvm 3.3-5ubuntu4 > > > > > > > > > > > > > > workaround: > > > > > > > I removed all noduplicate marker from declares and defines > > > > > > > > > > > > > > I saw these warnings too: > > > > > > > > > > > > > > In file included from > > > > > > > /usr/lib/llvm-3.3/include/clang/Basic/VersionTuple.h:19:0, > > > > > > > from > > > > > > > /usr/lib/llvm-3.3/include/clang/Basic/ObjCRuntime.h:18, > > > > > > > from > > > > > > > /usr/lib/llvm-3.3/include/clang/Basic/LangOptions.h:20, > > > > > > > from > > > > > > > /usr/lib/llvm-3.3/include/clang/Frontend/FrontendAction.h:22, > > > > > > > from > > > > > > > /usr/lib/llvm-3.3/include/clang/CodeGen/CodeGenAction.h:13, > > > > > > > from > > > > > > > > > > > > > > > > > > > /home/evil85/workspace/cpp/beignet_opencl_1_2/backend/src/backend/program.cpp:56: > > > > > > > /usr/lib/llvm-3.3/include/llvm/ADT/Optional.h: In > > > > > > > instantiation of > > > > ‘T* > > > > > > > llvm::Optional<T>::getPointer() [with T = unsigned int]’: > > > > > > > /usr/lib/llvm-3.3/include/llvm/ADT/Optional.h:123:76: required > > > > from ‘T& > > > > > > > llvm::Optional<T>::operator*() [with T = unsigned int]’ > > > > > > > /usr/lib/llvm-3.3/include/llvm/ADT/Optional.h:51:7: required > > from > > > > > > > ‘llvm::Optional<T>::Optional(llvm::Optional<T>&&) [with T = > > > > > > > unsigned > > > > > > int]’ > > > > > > > /usr/lib/llvm-3.3/include/clang/Basic/VersionTuple.h:60:14: > > > > required > > > > > > from > > > > > > > here > > > > > > > /usr/lib/llvm-3.3/include/llvm/ADT/Optional.h:114:79: warning: > > > > > > > dereferencing type-punned pointer will break strict-aliasing > > > > > > > rules [-Wstrict-aliasing] > > > > > > > /usr/lib/llvm-3.3/include/llvm/ADT/Optional.h: In > > > > > > > instantiation of > > > > ‘T* > > > > > > > llvm::Optional<T>::getPointer() [with T = bool]’: > > > > > > > /usr/lib/llvm-3.3/include/llvm/ADT/Optional.h:123:76: required > > > > from ‘T& > > > > > > > llvm::Optional<T>::operator*() [with T = bool]’ > > > > > > > /usr/lib/llvm-3.3/include/llvm/ADT/Optional.h:104:7: required > > from > > > > > > ‘void > > > > > > > llvm::Optional<T>::reset() [with T = bool]’ > > > > > > > /usr/lib/llvm-3.3/include/llvm/ADT/Optional.h:110:5: required > > from > > > > > > > ‘llvm::Optional<T>::~Optional() [with T = bool]’ > > > > > > > > > > > > > > > > > > > /usr/lib/llvm-3.3/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:397:27: > > > > > > > required from here > > > > > > > /usr/lib/llvm-3.3/include/llvm/ADT/Optional.h:114:79: warning: > > > > > > > dereferencing type-punned pointer will break strict-aliasing > > > > > > > rules [-Wstrict-aliasing] > > > > > > > > > > > > > > > > > > > > > > > > > > /home/evil85/workspace/cpp/beignet_opencl_1_2/backend/src/backend/program.cpp:652: > > > > > > > warning: the use of `tmpnam_r' is dangerous, better use `mkstemp' > > > > > > > > > > > > > > > > > > > > > I made something wrong ? Previous version (2013-12-05) compiled > > fine. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > Best Regards, > > > > > > > > > > > > > > Robert > > > > > > > > > > > > > _______________________________________________ > > > > > > > Beignet mailing list > > > > > > > <a href="mailto:Beignet@lists.freedesktop.org">Beignet@lists.freedesktop.org</a> > > > > > > > <a href="http://lists.freedesktop.org/mailman/listinfo/beignet" target="_blank">http://lists.freedesktop.org/mailman/listinfo/beignet</a> > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Best Regards, > > > > > > > > > > Robert > > > > > > > > > > > > > > > > -- > > > Best Regards, > > > > > > Robert > > > > > _______________________________________________ > > > Beignet mailing list > > > <a href="mailto:Beignet@lists.freedesktop.org">Beignet@lists.freedesktop.org</a> > > > <a href="http://lists.freedesktop.org/mailman/listinfo/beignet" target="_blank">http://lists.freedesktop.org/mailman/listinfo/beignet</a> > > > > _______________________________________________ > > Beignet mailing list > > <a href="mailto:Beignet@lists.freedesktop.org">Beignet@lists.freedesktop.org</a> > > <a href="http://lists.freedesktop.org/mailman/listinfo/beignet" target="_blank">http://lists.freedesktop.org/mailman/listinfo/beignet</a> > > _______________________________________________ > > Beignet mailing list > > <a href="mailto:Beignet@lists.freedesktop.org">Beignet@lists.freedesktop.org</a> > > <a href="http://lists.freedesktop.org/mailman/listinfo/beignet" target="_blank">http://lists.freedesktop.org/mailman/listinfo/beignet</a> > > > > > > -- > Best Regards, > > Robert </div></div></blockquote></div> <div> </div>-- Best Regards, Robert </div>