<div dir="ltr">use something like DEBUG_PRINT is better. Need to cleanup the whole library to fix this type of things.<div> </div><div>Thanks,</div><div>Zhigang Gong</div></div><div class="gmail_extra"> <div class="gmail_quote">On Tue, Nov 17, 2015 at 10:11 AM, Song, Ruiling <<a href="mailto:ruiling.song@intel.com" target="_blank">ruiling.song@intel.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Zhigang, Directly remove the output message may be not proper. The output message is very useful for us to debug if some application run into these kind of issues. Although we return the error code to application. But it is still hard to know exactly what's wrong if application just receives a CL_OUT_OF_RESOURCE. Maybe we can add a simple DEBUG_PRINT() macro to print some message under debug mode. What do you think? Thanks! Ruiling <div class="HOEnZb"><div class="h5"> > -----Original Message----- > From: Beignet [mailto:<a href="mailto:beignet-bounces@lists.freedesktop.org">beignet-bounces@lists.freedesktop.org</a>] On Behalf Of > Zhigang Gong > Sent: Friday, November 13, 2015 7:32 AM > To: <a href="mailto:beignet@lists.freedesktop.org">beignet@lists.freedesktop.org</a> > Cc: Gong, Zhigang <<a href="mailto:zhigang.gong@intel.com">zhigang.gong@intel.com</a>> > Subject: [Beignet] [PATCH] runtime: silent some error messages. > > We already set corresponding error code and return it to the caller. > Don't bother to print the error messages in beignet internal. > > Signed-off-by: Zhigang Gong <<a href="mailto:zhigang.gong@intel.com">zhigang.gong@intel.com</a>> > --- > src/cl_command_queue_gen7.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/src/cl_command_queue_gen7.c > b/src/cl_command_queue_gen7.c > index f0ee20a..96b23fb 100644 > --- a/src/cl_command_queue_gen7.c > +++ b/src/cl_command_queue_gen7.c > @@ -329,21 +329,18 @@ > cl_command_queue_ND_range_gen7(cl_command_queue queue, > > /* Compute the number of HW threads we need */ > if(UNLIKELY(err = cl_kernel_work_group_sz(ker, local_wk_sz, 3, > &local_sz) != CL_SUCCESS)) { > - fprintf(stderr, "Beignet: Work group size exceed Kernel's work group > size.\n"); > return err; > } > kernel.thread_n = thread_n = (local_sz + simd_sz - 1) / simd_sz; > kernel.curbe_sz = cst_sz; > > if (scratch_sz > ker->program->ctx->device->scratch_mem_size) { > - fprintf(stderr, "Beignet: Out of scratch memory %d.\n", scratch_sz); > return CL_OUT_OF_RESOURCES; > } > /* Curbe step 1: fill the constant urb buffer data shared by all threads */ > if (ker->curbe) { > kernel.slm_sz = cl_curbe_fill(ker, work_dim, global_wk_off, global_wk_sz, > local_wk_sz, thread_n); > if (kernel.slm_sz > ker->program->ctx->device->local_mem_size) { > - fprintf(stderr, "Beignet: Out of shared local memory %d.\n", > kernel.slm_sz); > return CL_OUT_OF_RESOURCES; > } > } > -- > 1.9.1 > > _______________________________________________ > Beignet mailing list > <a href="mailto:Beignet@lists.freedesktop.org">Beignet@lists.freedesktop.org</a> > <a href="http://lists.freedesktop.org/mailman/listinfo/beignet" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/beignet</a> _______________________________________________ Beignet mailing list <a href="mailto:Beignet@lists.freedesktop.org">Beignet@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/beignet" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/beignet</a> </div></div></blockquote></div> </div>