[cairo] test ft-font-create-for-ft-face fails

[sunmoon1997]

在 2005-12-07三的 21:04 -0800，Christian Biesinger写道：
> sunmoon1997 wrote:
> > hi,
> >   while running testsuit in cairo, the test ft-font-create-for-ft-face
> > failed with a pretty crash. After a quick look, the problem is
> > FcPatternAddString in fontconfig 2.4 branch doesn't accept null string
> > any more. The fix should be trivial, but I don't know the fix should go
> > cairo or fontconfig, so I attached both of them for review.
> 
> Note https://bugs.freedesktop.org/show_bug.cgi?id=4674
> 
For this bug:
- I think this test is not correct. A fresh empty pattern is
*meaningless*, you should pass it to fontconfig as input pattern to
match a font, then fontconfig will return a resolved pattern. You can
use this pattern whatever you want. 
- cairo_scaled_font_create should check font_face->status.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cairo-font-fix.diff
Type: text/x-patch
Size: 2121 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/cairo/attachments/20051208/77e28855/cairo-font-fix.bin