Hi there. Replies below.<br><br><div><span class="gmail_quote">On 12/15/05, <b class="gmail_sendername">Christian Biesinger</b> <<a href="mailto:cbiesinger@web.de">cbiesinger@web.de</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Bill Baxter wrote:<br>> The other thing I wasn't sure about was what to do about FontConfig stuff.<br>> I just ifdef'ed it out for MSVC, because as far as I can tell there isn't a<br>> version of fontconfig for Win32. Not sure if that will have any ill
<br>> effects. Not even really sure what fontconfig does.<br><br>Why are you building those files if you ifdef them out anyway?</blockquote><div><br>So things like cairo-ft are not necessary on Windows? I was thinking cairo-ft was the main font handling code. There aren't many comments in the code to give one an idea of which bits are supposed to work on which platforms, so I just tried to compile it all at first, and anything that seemed obviously wrong I removed (like Atsui,
e.g.). Those font files _almost_ work on Windows with the exception of fontconfig calls, so I just assumed someone had been sloppy about portability issues there.<br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Some notes on the patches:<br>+++ test/cairo-test.c 14 Dec 2005 23:44:11 -0000<br>- if (access (ref_name, F_OK) != 0) {<br>+#ifndef _WIN32<br>+ if (access (ref_name, F_OK) != 0)<br>+#endif<br>+ {<br><br>Seems like you could use _access (similar to _sprintf):
<br><a href="http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclib/html/_crt__access.2c_._waccess.asp">http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclib/html/_crt__access.2c_._waccess.asp
</a></blockquote><div><br>Ah, ok. I'll admit I was rather slipshod with my mods on the test programs. I wasn't really thinking to have those included back in. For instance I arbitrarily changed the delay parameter on glitz the test program to be tenths of seconds rather than whole seconds because I got tired of waiting 1second for every test.
<br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">src/cairo-font-subset.c<br>-static inline unsigned short<br>+static __inline unsigned short
<br><br>Why not INLINE from cairoint.h? Although it seems to me like this file<br>can currently only be used with Fontconfig.</blockquote><div><br>Yeh, good catch I think that was one of the first files I modified, before I realized the __inline__ thing was so widespread and before I found there was an INLINE macro used elsewhere.
<br></div><br>--bb<br></div>