[Clipart] SVG::Metadata re-engineering
bryce at bryceharrington.com
Mon Apr 4 15:26:07 PDT 2005
On Mon, Apr 04, 2005 at 12:53:02PM -0400, Nathan Eady wrote:
> Stephen Silver wrote:
> >After some searching I think I've found what is doing this, it's
> >the following line in Metadata.pm:
> > return encode_entities($text);
> Yep, I had found that, and it was on my TODO list of things to
> adjust when I work over SVG::Metadata. I also want to fully grok
> the XML::Twig stuff in sub parse, so that I understand completely
> what is going on there, try to finish up some of the items that are
> marked TODO in the comments in that sub, especially publisher_url,
> and add an option to retain the SVG, with a corresponding to_svg
> method that replaces the old metadata from the parsed SVG with
> that generated by to_rdf and returns the whole thing as valid
> SVG content. Also there are several TODO comments in to_rdf
> that I might try to clean up if I have time.
> Speaking of that: Bryce, if you have any pending changes to
> Metadata.pm that aren't in the latest version on the CPAN, can
> you send them my way, so we don't have to end up merging two
> sets of changes?
I don't have any pending changes, other than the patch that was posted
here. I'm figuring given that patch it'll be time to release a new
version so if there are any other changes folks need, this'd be a good
time to get 'em in.
Btw, iirc, that encode_entities() bit was added in there at someone
else's request (Jonadab?) to fix a different issue, so the one thing
I'm curious about is if removing it might cause the other bug to recur.
(Maybe it had something to do with foreign characters in the metadata?)
I figure it should be easy to check it by just re-running it over the
entire clipart package and see what turns up.
More information about the clipart