<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hey chovynz,<div><br></div><div>Good work. I've added the inherit to your requested comment widgets & updated their sql to remove the join dependency. Also, I updated the management bar links to use the new widget.</div><div><br></div><div>I'll let you close out that bug, if this resolves the rest of your issues with that.</div><div><br></div><div>Cheers,</div><div>+Brad</div><div><br></div><div><div>On Aug 14, 2011, at 7:16 PM, chovynz wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Hi all<br><br>I will also be sending this to LP, but I wanted to let Jon and Brad know specifically.<br><br><b>Bug Description:</b><br>Links to clipart detail pages are not consistent throughout the site. The many different links inside the code are tedious and annoying to update.<br>
<br><b>Partial Bug Fix:</b><br>I have gone throughout the site and updated many clipart detail links to a new widget, so that if the structure of links to clipart detail pages needs to gets changed, <b><i><u>you only need to do it once (inside the new widget)!</u></i></b> A good example of this is the recent trouble we had with pretty url's and no comments displaying. This update will allow very quick changes to the entire site, wherever there is a link to clipart detail pages.<br>
<b><br>New Widget:</b><br>1885 link-to-detail<br><br><span class="xml-punctuation"><b>Content of new widget:</b><br>< </span><span class="xml-tagname">a </span><span class="xml-attname">href</span><span class="xml-punctuation">=</span><span class="xml-attribute">"[root]/detail/((id))/((link))"</span><span class="xml-punctuation"> ></span><br>
<br><b>Affected widgets:<br></b> (replaced each hardcoded link with <span class="xml-text">(#(inherent:1885|SELECT * FROM ocal_files WHERE id = ((id)) LIMIT 1)#))</span><ul><li>31 clipart-thumb<br></li><li>163 bydate</li>
<li>23 fortags-img (sysGod version)<br></li><li>145 fortags-img X 2 (content and authorised content)</li><li>103 user-detail<br></li><li><br></li></ul><b>TODO:<br></b><ol><li>(my) old SQL is blocking the completion of this bugfix, and I don't know the "ocalfiles.users" way. I would appreciate it if someone could update the sql and content to be compatible with this new widget/method in widgets:</li>
</ol><ul><ul><li>1117 latest-comments-box</li><li>1147 list-personal-comments<br></li></ul></ul><ol><li><i>Management Action bar Ajax </i>is something I don't know where to update the clipart detail link. I have had a look around and cannot find where to change the link to this new method. Brad please make the link point to this widget the same way as in bydate. -> <span class="xml-text">(#(inherent:1885|SELECT * FROM ocal_files WHERE id = ((id)) LIMIT 1)#)</span> </li>
</ol>OCAL became "unavaliable" while I was working on it. Hopefully the changes have remained. I wasn't doing anything that would make the site crash so I don't think it was me. I will add more once OCAL becomes alive again.<br>
<b><br></b>-- <br>Cheers<br>Chovynz<br>
_______________________________________________<br>clipart mailing list<br><a href="mailto:clipart@lists.freedesktop.org">clipart@lists.freedesktop.org</a><br><a href="http://lists.freedesktop.org/mailman/listinfo/clipart">http://lists.freedesktop.org/mailman/listinfo/clipart</a><br></blockquote></div><br></body></html>