[Cogl] [PATCH v3] Adds initial GLES2 integration support

Neil Roberts neil at linux.intel.com
Wed May 16 08:11:27 PDT 2012


Looks good, thanks. I still have some really minor changes to suggest
though -

• I couldn't get it to build to build without including cogl-queue.h
  from cogl-gles2-context-private.h. Not sure why, but this was building
  for WebOS so maybe other builds end up including it via something
  else?

• The wrapper for glCopyTexSubImage2D actually calls glCopyTexImage2D

• A _COGL_RETURN_IF_FAIL assertion wasn't updated to use the inline
  GQueue so it wouldn't compile.

Here's the changes in patch form to squash in if you want.

Otherwise looks good to me.

Reviewed-by: Neil Roberts <neil at linux.intel.com>

Regards,
- Neil

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch
Type: text/x-diff
Size: 1493 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/cogl/attachments/20120516/20050a49/attachment.diff>


More information about the Cogl mailing list