[Cogl] [PATCH] Remove the varying array for tex_coords

Neil Roberts neil at linux.intel.com
Fri Sep 28 09:06:39 PDT 2012


This looks good to me apart from one minor comment:

Robert Bragg <robert at sixbynine.org> writes:

>    g_string_set_size (ctx->codegen_source_buffer, 0);
>    g_string_append_printf (ctx->codegen_source_buffer,
> -                          "cogl_texture_matrix[%i]", state->unit);
> +                          "cogl_texture_matrix%i", state->unit);

The uniform for the texture matrix is named after the layer number, so
it looks like we need to change this to layer_index instead of
state->unit.

Reviewed-by: Neil Roberts <neil at linux.intel.com>

Regards,
- Neil


More information about the Cogl mailing list