<html> <head> <meta content="text/html; charset=UTF-8" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">Hi Robert, I just updated my branch on <meta http-equiv="content-type" content="text/html; charset=UTF-8"> <a href="https://git.gnome.org/browse/cogl/log/?h=lionel/introspection-next">https://git.gnome.org/browse/cogl/log/?h=lionel/introspection-next</a> Inline my responses : On 25/11/13 16:59, Robert Bragg wrote: </div> <blockquote cite="mid:CAMou1-1EKAYvUyL8UuK9VH+2XBE=T46DqtYVOboM-V299hYQWg@mail.gmail.com" type="cite"> <pre wrap="">Thanks this looks good. One thing we've discussed before that would be good to tweak is that every CoglObject instance now has a GTypeInstance member but I think this may be redundant. We already have a klass pointer that basically serves the same purpose of pointing to a corresponding per-type class description. Hopefully we can just cast the klass pointer to a GTypeInstance where necessary.</pre> </blockquote> Verified, it works, so I just dropped the GTypeInstance member. <blockquote cite="mid:CAMou1-1EKAYvUyL8UuK9VH+2XBE=T46DqtYVOboM-V299hYQWg@mail.gmail.com" type="cite"> <pre wrap=""> Another thing is that it looks like the cogl_gtype_XYZ_get_type() functions have been renamed to cogl_XYZ_get_gtype() instead. It could be nice to avoid needing duplicates for these functions but I wonder if we might break something if we change these function names? It the gobject introspection scanner can't work with the cogl_gtype_ namespace then maybe we should see if we get away with this rename - at least it doesn't look like clutter or gnome-shell refer to the current names - and we can add the current names back later if it turns out we break something?</pre> </blockquote> I run into problems when trying to get the scanner to parse these "cogl_gtype_" functions. Probably because of the namespace. For CoglPath I had to add the "cogl2_path_" namespace to the parser to get the parser to include these into the introspection data. I might try that later. <blockquote cite="mid:CAMou1-1EKAYvUyL8UuK9VH+2XBE=T46DqtYVOboM-V299hYQWg@mail.gmail.com" type="cite"> <pre wrap=""> Is it perhaps possible to avoid needing the COGL_GTYPE_DEFINE_CLASS macro since it seems to be used wherever we use COGL_OBJECT_DEFINE[_WITH_CODE] and takes the same arguments? Sorry that this would reduce you're Ohloh points ;-)</pre> </blockquote> I need to check whether it will make stuff complicated with deprecated types. <blockquote cite="mid:CAMou1-1EKAYvUyL8UuK9VH+2XBE=T46DqtYVOboM-V299hYQWg@mail.gmail.com" type="cite"> <pre wrap=""> Would you mind if we don't expose new gtype apis for deprecated Cogl apis such as the CoglShader, CoglProgram and CoglVertexBuffer apis?</pre> </blockquote> Done on the new branch. <blockquote cite="mid:CAMou1-1EKAYvUyL8UuK9VH+2XBE=T46DqtYVOboM-V299hYQWg@mail.gmail.com" type="cite"> <pre wrap=""> thanks a lot for looking at this, Robert On Fri, Nov 15, 2013 at 3:44 PM, Lionel Landwerlin <a class="moz-txt-link-rfc2396E" href="mailto:llandwerlin@gmail.com"><llandwerlin@gmail.com></a> wrote: </pre> <blockquote type="cite"> <pre wrap="">Hi everyone, I just pushed the second of introspection commits to get Cogl usable from Gjs. The branch containing the commits is available here : <a class="moz-txt-link-freetext" href="https://git.gnome.org/browse/cogl/log/?h=lionel/introspection-next">https://git.gnome.org/browse/cogl/log/?h=lionel/introspection-next</a> This work has been rebase from a previous iteration against the cogl-1.18 branch. I managed to used quite a bit of the API, including stuff from CoglGst/CoglPath. Hopefully this work can be landed soon. Cheers, - Lionel _______________________________________________ Cogl mailing list <a class="moz-txt-link-abbreviated" href="mailto:Cogl@lists.freedesktop.org">Cogl@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="http://lists.freedesktop.org/mailman/listinfo/cogl">http://lists.freedesktop.org/mailman/listinfo/cogl</a> </pre> </blockquote> </blockquote> </body> </html>