[compiz] Re: [Mesa3d-dev] EXT_texture_from_pixmap update

[Brian Paul]

Ian Romanick wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> David Reveman wrote:
> 
>>Patch for mesa with a set of updates for EXT_tfp. Includes necessary
>>FBConfig support, adds attrib_list to BindTexImage and fixes
>>CreateDrawable so that glXCreatePixmap works.
>>
>>Xgl and compiz requires this patch.
>>
>>Can I commit this to head?
> 
> 
> Other than my one comment below, this looks good.
> 
> 
>>Index: include/GL/internal/glcore.h
>>===================================================================
>>RCS file: /cvs/mesa/Mesa/include/GL/internal/glcore.h,v
>>retrieving revision 1.8
>>diff -u -r1.8 glcore.h
>>--- include/GL/internal/glcore.h	6 Jun 2004 02:20:20 -0000	1.8
>>+++ include/GL/internal/glcore.h	9 Apr 2006 10:46:54 -0000
>>@@ -136,6 +136,13 @@
>>     /* OML_swap_method */
>>     GLint swapMethod;
>> 
>>+    /* EXT_texture_from_pixmap */
>>+    GLint bindToTextureRgb;
>>+    GLint bindToTextureRgba;
>>+    GLint bindToMipmapTexture;
>>+    GLint bindToTextureTargets;
>>+    GLint yInverted;
>>+
>>     GLint screen;
>> } __GLcontextModes;
> 
> 
> Aieeee!!!  Additions to __GLcontextModes *MUST* go at the end.  Any
> driver compiled against an old version of the structure will get a nasty
> surprise if it tries to access the screen field. :)

That's critical information which must be documented in the code.

Ian, would you please update the comments in glcore.h accordingly?

-Brian