[compiz] [PATCH] Fix screenshot command

Dan Winship danw at novell.com
Fri Apr 14 08:24:05 PDT 2006


reggaemanu wrote:
> Here is a patch to fix the segfault issue with command_screenshot and
> window_command_screenshot.

Er? What segfault issue? Was this brought up somewhere else?

> It also avoid the conflict between this two functions if both contain
> the same key (Print and <Alt>Print for example)
> (actually if you press <Alt>Print both commands are triggered)

Hm... but it just switches the problem around, right? So that if you
swapped the bindings so that "Print" was "run_command_window_screenshot"
and "<Alt>Print" was "run_command_screenshot", then "<Alt>Print" would
trigger both of them? To really fix it, it needs to be checking that
there are no extraneous modifiers held down. Then it can check the
bindings in any order and it will work, regardless of what keys are
bound to what.

-- Dan


More information about the compiz mailing list