[compiz] [PATCH] Annotate shapes, text and dbus support

David Reveman davidr at novell.com
Wed Nov 15 09:29:15 PST 2006


On Mon, 2006-11-13 at 06:15 +0000, Mike Dransfield wrote:
> Here are my patches to add extra shapes to the annotate
> plugin.  I have also added dbus support and made a few things
> configurable.
> 
> The new tools available are Line, Rectangle and Circle, the
> original is called Brush.  There is no selection line at the
> moment because I do not understand OpenGL yet.  Hopefully
> these patches can be added and something added later.

I'm not sure what you mean by selection line but interactive drawing
with these tools will require us to draw into an intermediate buffer
that we blend on top of the previous content. We can add that later
though.

> 
> There is an extra action called initiate_remote.  This is only
> used by dbus and should probably be hidden in gconf.

I didn't like the initiate_remote name. I change the name to 'draw'.

> 
> I had a problem getting colors from dbus, it appears that they
> are not supported yet.  I commented the code that should work
> but doesn't.

I fixed that.

> 
> I added text support but only via dbus.  There are certain problems
> with typing directly to the screen.  You can write to the screen with
> a dbus command like this.
> 
> dbus-send --type=method_call --dest=org.freedesktop.compiz  \
> /org/freedesktop/compiz/annotate/allscreens/remote_initiate \
> org.freedesktop.compiz.activate string:'root' \
> int32:`xwininfo -root | grep id: | awk '{ print $4 }'` \
> string:tool string:text string:x double:1000 string:y double:200 \
> string:text string:"Hello World" string:family string:Sans \
> string:size double:92.0  string:stroke_width double:1.0 \
> string:slant string:italic
> 
> All of the tools are available this way too.

I changes so all these tools are available only through the 'draw'
option. We need do drawing to an intermediate buffer as I mentioned
above before it makes sense to allow interactive use of these tools.

I've pushed this out, but I haven't verified that it actually works. Let
me know if I broke something while doing these changes.

Thanks,

-David



More information about the compiz mailing list