[compiz] Zoom plugin filter linear?

[David Reveman]

On Wed, 2007-02-14 at 08:54 +0100, Bellegarde Cedric wrote:
> http://gitweb.freedesktop.org/?p=xorg/app/compiz.git;a=blobdiff;h=7ebfdccdaccfe12749e7123fba5271f430fb9e5f;hp=59d3ce75d24296751120916144c057114fad1f14;hb=d32ac34676f2a87d60ad9e4fe426281595c5b859;f=plugins/zoom.c
> 
> David, when you add my zoom plugin patch factor, you add this:
> 
> +        if (zs->zoomFactor == 2.0f &&
> +            (zs->opt[ZOOM_SCREEN_OPTION_FILTER_LINEAR].value.b ||
> +             zs->zVelocity != 0.0f))
>              s->filter[SCREEN_TRANS_FILTER] = COMP_TEXTURE_FILTER_GOOD;
>          else
>              s->filter[SCREEN_TRANS_FILTER] = COMP_TEXTURE_FILTER_FAST;
> 
> It make filter linear disabled when zoom factor != 2 :(
> Any reason? I remove this and it seems to work well here.

I just thought it looked bad with nearest filtering when scale factor is
not a multiple of two. btw, we should be looking at the CompTransform
matrix to determine which filter to use instead of the zoomFactor but we
can fix that later when ScreenAttribute struct and transform fields in
WindowAttribute struct have been killed.

- David