[compiz] Re: [PATCH]Application-window switcher, and comments for switcher.c

David Reveman davidr at novell.com
Wed Feb 21 04:28:25 PST 2007


On Thu, 2007-02-15 at 22:23 +1100, Christopher Halse Rogers wrote:
> Sorry, this time with the actual patches attached!

Great work!

Wouldn't it make sense to have an enum for the switch type currently
used instead of two boolean values (allWindows and appWindows)? It seems
that allWindows is currently always FALSE when appWindows is TRUE, which
btw is different from the scale plugin where scaling a group will always
include group windows from all viewports.

Most of the comments looks useful so I'm happy with including those.

- David



More information about the compiz mailing list