[compiz] removing string restrictions

David Reveman davidr at novell.com
Fri May 11 08:15:58 PDT 2007


On Fri, 2007-05-11 at 11:45 +0200, Dennis Kasprzyk wrote:
> Am Donnerstag, 10. Mai 2007 21:24 schrieb David Reveman:
> > We've previously discussed if we should add some sort of selection
> > option type and not use string options and string restrictions for that
> > purpose.
> >
> > I don't think we need a new option type for this. The integer type
> > should do just fine. The attached patch changes the blur plugin's filter
> > option from string to integer type and adds the relevant metadata. I
> > suggest that we change all existing options that use string restrictions
> > in a similar way and remove the string restrictions completely.
> >
> > Questions? Does it sounds OK?
> >
> > - David
> 
> I like the idea, but I would prefer a different XML style.  
> <desc>
> 	<_name value="1">Foo</_name>
> 	<_name value="2">Foo2</_name>
> 	<_name value="3">Foo3</_name>
> </desc>  

I wanted the <desc> tag to look the same for every option type and not
all option type values can be represented as strings. e.g. actions. All
option values in the meta data are currently within tags, hence it makes
sense to keep these values within tags as well.

- David



More information about the compiz mailing list