[compiz] [PATCH] Water fixes

[David Reveman]

On Mon, 2007-05-14 at 15:07 -0500, Erkin Bahceci wrote:
> On 5/14/07, David Reveman <davidr at novell.com> wrote:
> > Great, I've committed all patches except
> > Stop-Water-drawing-right-after-waves-disappear as I'm not sure how you
> > came to the conclusion that the count variable could be decremented at
> > that rate. Did you make any calculations to come up with that or is it
> > just based on testing on your machine?
> 
> 
> Just by testing a few values. Since the decrement is happening where
> the water update takes place (both independent of msSinceLastPaint),
> it should work on any machine. Is it not the case?

It can give slightly different results depending on if the software or
hardware water simulation is used but it should be close enough to not
really matter. However, when I use your patch I see cases where I find
it to end the water simulation much too early. E.g. when you turn off
the rain effect and rain_delay is set to 1.

- David