[compiz] CompRect modification

Sam Spilsbury smspillaz at gmail.com
Mon Mar 2 14:13:20 PST 2009


On Tue, Mar 3, 2009 at 7:12 AM, Sam Spilsbury <smspillaz at gmail.com> wrote:
> On Mon, Mar 2, 2009 at 9:05 PM, Danny Baumann <dannybaumann at web.de> wrote:
>> Hi,
>>
>>> >> Personally, I'd like to see x1/y1/x2/y2 instead of
>>> >> left/top/right/bottom. The reason is that while left etc. is the
>>> >> somewhat clearer term, x1 etc. is the more commonly used term for
>>> >> defining rectangles.
>>> >
>>> > Oh, and what I forgot: Wouldn't it be a good idea to derive
>>> > CompWindow::Geometry from CompRect? After all, CompWindow::Geometry is
>>> > just the window rectangle + border size handling.
>>> >
>>> > (and on a slightly related question, wouldn't it also be a good idea to
>>> > add a function that returns a CompRect with window size including frame
>>> > to CompWindow?)
>>> >
>>
>>> I don't know if such a function exists. But it would be nice to add
>>> functions that return a BOX, Box, XRectangle and Region. We need to
>>> use these for X.org functions.
>>
>> Do you have any specific Xlib functions that would need that in mind?
>
 I'm not particularly sure of any use cases right now, but I think it
 could end up being a useful point in there are some. Of course, such
 changes can always be delayed until plugins actually need them.
>
>>
>>> Also, doesn't eduardo's patch cover place.cpp?
>>
>> Nope, it doesn't. It's no problem though, I'll convert it.
>>
>> Regards,
>>
>> Danny
>>
>>
>
>
>
> --
> Sam Spilsbury
>

Regards,

Sam

-- 
Sam Spilsbury


More information about the compiz mailing list