Well, I figured out the problem, and it's not present in the originial minimize.c, but instead in the Quinn patched minimize.c. A } was moved below that else segment, thus moving which if statement it is attached to. In Quinn's version that else statement attaches to the second evaluation instead (!mw->adjust). So there was nothing wrong with the original, sorry for any confusion. I'll post something about this on the
<a href="http://compiz.net">compiz.net</a> messageboard.<br><br>
<div><span class="gmail_quote">On 7/10/06, <b class="gmail_sendername">David Reveman</b> <<a href="mailto:davidr@novell.com">davidr@novell.com</a>> wrote:</span>
<blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">On Mon, 2006-07-10 at 09:43 -0700, John Hess wrote:<br>> Sorry, unfortunately it doesn't fix it. The problem is that the
<br>> section you added it to doesn't execute if w->invisible is true, and<br>> so if a window is on another viewport then the window never gets it's<br>> scaling fixed.<br><br>hm, it does execute if w->invisible is true as it executes when the
<br>following check fails:<br><br>if (!w->invisible &&<br> (ms->wMask & w->type) &&<br> minGetWindowIconGeometry (w, &mw->icon))<br><br>The only difference I see in your patch is that if w->invisible is true
<br>the moveWindow call that should position the window at it's correct<br>position is not called and I fail to see why this would fix anything. I<br>suspect that the problem is somewhere else.<br><br>I don't see any artifacts when unminimizing window that are not on the
<br>current viewport. Does it happen to all applications for you?<br><br><br>-David<br><br></blockquote></div><br><br clear="all"><br>-- <br>.: Animacide :.