[ConsoleKit] Review for bug 26055
halton.huo at gmail.com
Tue May 18 21:54:47 PDT 2010
Please review the updated patch with solution #2,
On Wed, 2010-05-19 at 12:25 +0800, Halton Huo wrote:
> On Solaris, ck_get_max_num_consoles() always return number whatever
> vtdaemon enable or disable. I'd make new patch based on solution #2.
> On Tue, 2010-05-18 at 10:10 -0400, Ray Strode wrote:
> > So looking at ConsoleKit more, I see that it puts ifdefs in very
> > specific parts of the code and avoids it elsewhere.
> > Reading through ConsoleKit more, i think the right approach is one of:
> > 1) drop is_vt_enabled and use ck_get_max_num_consoles (&num_consoles);
> > ... if (.... && num_consoles > 0)
> > or if that won't work
> > 2) Add ck_supports_activatable_consoles to ck-sysdeps.h. In
> > ck-sysdeps-linux and ck-sysdeps-freebsd unconditionally return TRUE.
> > In ck-sysdeps-solaris, have your code.
> > 1 is probably the smallest patch, assuming get_max_num_consoles
> > returns 0 like I think it should in solaris.
More information about the ConsoleKit