dbus/doc TODO, 1.38, 1.39 dbus-specification.xml, 1.8, 1.9 dbus-test-plan.xml, 1.1, 1.2

[Kristian Hogsberg]

Update of /cvs/dbus/dbus/doc
In directory pdx:/tmp/cvs-serv12926/doc

Modified Files:
	TODO dbus-specification.xml dbus-test-plan.xml 
Log Message:
2004-05-17  Kristian Høgsberg  <krh at redhat.com>

	Remove base64 encoding, replace with hex encoding. Original patch
	from trow at ximian.com, added error handling.

	* dbus/dbus-string.c (_dbus_string_base64_encode)
	(_dbus_string_base64_decode): Remove.
	(_dbus_string_hex_decode): Add end_return argument so we can
	distinguish between OOM and invalid hex encoding.
	(_dbus_string_test): Remove base64 tests and add test case for
	invalid hex.

	* dbus/dbus-keyring.c, dbus/dbus-auth-script.c, dbus/dbus-auth.c:
	Replace base64 with hex.

	* test/data/auth/invalid-hex-encoding.auth-script: New test case
	for invalid hex encoded data in auth protocol.



Index: TODO
===================================================================
RCS file: /cvs/dbus/dbus/doc/TODO,v
retrieving revision 1.38
retrieving revision 1.39
diff -u -d -r1.38 -r1.39
--- a/TODO	7 May 2004 22:45:15 -0000	1.38
+++ b/TODO	17 May 2004 22:19:04 -0000	1.39
@@ -118,10 +118,6 @@
 
  - recursive dispatch, see dbus_connection_dispatch()
 
- - the auth protocol may as well use hex encoding instead of 
-   base64, then we can dump the base64 implementation and 
-   save some bloat.
-
  - Better error checking for bogus configuration files. Currently if a 
    configuration file tries to include itself the bus crashes on start. We 
    should probably have a check against this.

Index: dbus-specification.xml
===================================================================
RCS file: /cvs/dbus/dbus/doc/dbus-specification.xml,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -d -r1.8 -r1.9
--- a/dbus-specification.xml	11 May 2004 18:31:34 -0000	1.8
+++ b/dbus-specification.xml	17 May 2004 22:19:04 -0000	1.9
@@ -911,7 +911,7 @@
       <title>DATA Command</title>
       <para>
         The DATA command may come from either client or server, and simply 
-        contains a base64-encoded block of data to be interpreted 
+        contains a hex-encoded block of data to be interpreted 
         according to the SASL mechanism in use.
       </para>
       <para>

Index: dbus-test-plan.xml
===================================================================
RCS file: /cvs/dbus/dbus/doc/dbus-test-plan.xml,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -d -r1.1 -r1.2
--- a/dbus-test-plan.xml	30 Sep 2003 03:34:00 -0000	1.1
+++ b/dbus-test-plan.xml	17 May 2004 22:19:04 -0000	1.2
@@ -135,7 +135,7 @@
           ## this tests a successful auth of type EXTERNAL
           
           SERVER
-          SEND 'AUTH EXTERNAL USERNAME_BASE64'
+          SEND 'AUTH EXTERNAL USERNAME_HEX'
           EXPECT_COMMAND OK
           EXPECT_STATE WAITING_FOR_INPUT
           SEND 'BEGIN'