dbus/doc TODO,1.74,1.75 dbus-specification.xml,1.33,1.34

[Havoc Pennington]

Update of /cvs/dbus/dbus/doc
In directory gabe:/tmp/cvs-serv18237/doc

Modified Files:
	TODO dbus-specification.xml 
Log Message:
2005-05-05  Havoc Pennington  <hp at redhat.com>

	* configure.in (LT_*): add notes on how the libtool versioning
	works to save thinking. Increment soname to indicate protocol
	breakage (though really the library interface hasn't changed I
	guess)

	* dbus/dbus-transport.c (_dbus_transport_get_is_authenticated):
	verify the GUID received from server matches what we were
	expecting, if we had an expectation

	* dbus/dbus-auth.c (send_ok): send GUID along with the OK command
	(_dbus_auth_get_guid_from_server): new function
	(send_begin): parse the OK args

	* doc/dbus-specification.xml: add GUID to the auth protocol



Index: TODO
===================================================================
RCS file: /cvs/dbus/dbus/doc/TODO,v
retrieving revision 1.74
retrieving revision 1.75
diff -u -d -r1.74 -r1.75
--- TODO	13 Apr 2005 16:13:42 -0000	1.74
+++ TODO	5 May 2005 22:02:11 -0000	1.75
@@ -31,10 +31,6 @@
 
  - dbus-pending-call.c has some API and thread safety issues to review
 
- - transmit GUID from server to client in the auth protocol, so 
-   connections can be shared even if the address used to connect
-   to them didn't have a GUID in it.
-
  - Add test harness for selinux allow/deny cf. this message
    http://lists.freedesktop.org/archives/dbus/2005-April/002506.html
 
@@ -63,6 +59,9 @@
 Can Be Post 1.0
 ===
 
+ - if the GUID is obtained only during authentication, not in the address, 
+   we could still share the connection
+
  - Allow a dbus_g_proxy_to_string()/g_object_to_string() that
    would convert the proxy to an "IOR" and dbus_g_proxy_from_string()
    that would decode; using these, dbus-glib users could avoid

Index: dbus-specification.xml
===================================================================
RCS file: /cvs/dbus/dbus/doc/dbus-specification.xml,v
retrieving revision 1.33
retrieving revision 1.34
diff -u -d -r1.33 -r1.34
--- dbus-specification.xml	25 Feb 2005 22:03:30 -0000	1.33
+++ dbus-specification.xml	5 May 2005 22:02:11 -0000	1.34
@@ -1337,7 +1337,7 @@
 
         <itemizedlist>
 	  <listitem><para>REJECTED &lt;space-separated list of mechanism names&gt;</para></listitem>
-	  <listitem><para>OK</para></listitem>
+	  <listitem><para>OK &lt;GUID in hex&gt;</para></listitem>
 	  <listitem><para>DATA &lt;data in hex encoding&gt;</para></listitem>
 	  <listitem><para>ERROR</para></listitem>
 	</itemizedlist>
@@ -1478,6 +1478,10 @@
         The server must not accept additional commands using this protocol 
         after the OK command has been sent.
       </para>
+      <para>
+        The OK command has one argument, which is the GUID of the server.
+        See <xref linkend="addresses"/> for more on server GUIDs.
+      </para>
     </sect2>
     <sect2 id="auth-command-error">
       <title>ERROR Command</title>
@@ -1516,7 +1520,7 @@
             (MAGIC_COOKIE is a made up mechanism)
 
             C: AUTH MAGIC_COOKIE 3138363935333137393635383634
-            S: OK
+            S: OK 1234deadbeef
             C: BEGIN
           </programlisting>
 	</figure>
@@ -1528,7 +1532,7 @@
             C: AUTH SKEY 7ab83f32ee
             S: DATA 8799cabb2ea93e
             C: DATA 8ac876e8f68ee9809bfa876e6f9876g8fa8e76e98f
-            S: OK
+            S: OK 1234deadbeef
             C: BEGIN
           </programlisting>
 	</figure>
@@ -1538,7 +1542,7 @@
             C: FOOBAR
             S: ERROR
             C: AUTH MAGIC_COOKIE 3736343435313230333039
-            S: OK
+            S: OK 1234deadbeef
             C: BEGIN
           </programlisting>
 	</figure>
@@ -1550,7 +1554,7 @@
             C: AUTH SKEY 7ab83f32ee
             S: DATA 8799cabb2ea93e
             C: DATA 8ac876e8f68ee9809bfa876e6f9876g8fa8e76e98f
-            S: OK
+            S: OK 1234deadbeef
             C: BEGIN
           </programlisting>
 	</figure>
@@ -1566,7 +1570,7 @@
             C: AUTH SKEY 7ab83f32ee
             S: DATA 8799cabb2ea93e
             C: DATA 8ac876e8f68ee9809bfa876e6f9876g8fa8e76e98f
-            S: OK
+            S: OK 1234deadbeef
             C: BEGIN
           </programlisting>
 	</figure>
@@ -1582,7 +1586,7 @@
             C: AUTH SKEY 7ab83f32ee
             S: DATA 8799cabb2ea93e
             C: DATA 8ac876e8f68ee9809bfa876e6f9876g8fa8e76e98f
-            S: OK
+            S: OK 1234deadbeef
             C: BEGIN
           </programlisting>
 	</figure>