[patch] improved SELinux auditing

Havoc Pennington hp at redhat.com
Mon Nov 8 08:42:33 PST 2004


On Sun, 2004-11-07 at 19:08 -0500, Colin Walters wrote:
> +#include <stdio.h>

Should not do this... better to abstract it in sysdeps or dbus-string

> +static void
> +log_audit_callback (void *data, security_class_t class, char *buf,
> size_t bufleft)
> +{
> +  DBusString *audmsg = data;
> +  snprintf (buf, bufleft, "%s", _dbus_string_get_const_data
> (audmsg));

For this I'd rather have _dbus_string_set_length(audmsg, bufleft)
(or is it bufleft-1)

The patch you sent seems truncated or something for the changes to
selinux.c?

Havoc




More information about the dbus mailing list