[guus@debian.org: Bug#290306: dbus-1-dev: silly typedefs]

[Sjoerd Simons]

We just got the mail below from a debian user/developer. He raises some valid
points imho.

----- Forwarded message from Guus Sliepen <guus@debian.org> -----

Date: Thu, 13 Jan 2005 15:14:06 +0100
From: Guus Sliepen <guus@debian.org>
Subject: Bug#290306: dbus-1-dev: silly typedefs
To: Debian Bug Tracking System <submit@bugs.debian.org>
Reply-To: Guus Sliepen <guus@debian.org>, 290306@bugs.debian.org
X-Mailer: reportbug 3.5

Package: dbus-1-dev
Version: 0.22-4
Severity: normal
Tags: upstream

The file dbus-types.h contains very silly typedefs that will probably
break on any architecture where an int does not have the same size or
signedness as on i386:

typedef unsigned int   dbus_bool_t;
typedef unsigned short dbus_uint16_t;
typedef short          dbus_int16_t;
typedef unsigned int   dbus_uint32_t;
typedef int            dbus_int32_t;
typedef dbus_uint32_t  dbus_unichar_t;

It also introduces its own types, while there are perfectly well defined
and standardised types that do exactly what dbus needs in stdint.h
(int16_t, uint16_t, etc.) and stdbool.h (bool). At best DBus's
proprietary typedefs will confuse a programmer, and in the worst case it
will break on other architectures.


-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.9-skas3-v7
Locale: LANG=nl_NL.UTF-8, LC_CTYPE=nl_NL.UTF-8 (charmap=UTF-8)

Versions of packages dbus-1-dev depends on:
ii  dbus-1                        0.22-4     simple interprocess messaging syst
ii  pkg-config                    0.15.0-4   Manage compile and link flags for 

-- no debconf information

----- End forwarded message -----

-- 
The Shuttle is now going five times the sound of speed.
		-- Dan Rather, first landing of Columbia