[PATCH] was Re: Signature length limit

Havoc Pennington hp at redhat.com
Fri Oct 21 08:10:39 PDT 2005


On Tue, 2005-10-18 at 14:34 -0400, John (J5) Palmieri wrote:
> Here is a simple patch which ups the limit to 65535 (two bytes).  Is
> this too big?  It passes make check.  I looked through the code to see
> if we actually restrict the length to one byte in the header but it
> looks like we are just appending a dbus string so upping the max value
> should just work.  Let me know if I am wrong on this and other code
> needs to be touched.  

I think make check only passes because it never sends a length > 255 ...
if you add a test for a longer signature I bet it will fail. Remember
that the spec would also need updating to reflect this change.

Havoc




More information about the dbus mailing list