[PATCH] Privatize the DBusPendingCall struct

Havoc Pennington hp at redhat.com
Wed Jul 26 08:53:01 PDT 2006


John (J5) Palmieri wrote:
> Patch looks good and I have been running it for a day now.  Nothings 
> seems out of the ordinary.

Remember most things won't init threads so won't run into problems 
here... anyone on the list using threads want to test this too?

> As for the timeout bug I fixed instead of getting the asserts we get get 
> activation errors but I think these are expected.  The error message 
> changed but I believe that was your doing to make it more clear.  
> Sometimes it is hard to tell what is supposed to fail and how they are 
> supposed to fail.

Really we need to fix it so make check never prints errors... I think 
the errors are printed by the activated programs while testing 
activation... so possible solutions might be to pass env variables or 
options to the activated apps indicating what errors are expected, or 
something like that, and suppress the printing of stuff when appropriate...

Havoc



More information about the dbus mailing list