[patch] standard_session_servicedirs (was Re: OLPC and .service files in a users home directory)

John (J5) Palmieri johnp at redhat.com
Thu Nov 2 09:37:05 PST 2006


On Thu, 2006-11-02 at 18:28 +0100, uwesmail2005-lkml at yahoo.de wrote:
> --- "John (J5) Palmieri" <johnp at redhat.com> schrieb:
> 
> > On Thu, 2006-11-02 at 13:53 +0100, uwesmail2005-lkml at yahoo.de wrote:
> 
> > > Why not use
> > element_type_to_name(ELEMENT_STANDARD_SESSION_SERVICEDIRS)
> > > here? It would make maintaining (renaming the XML-Element) easier.
> > 
> > Next time please cut the code so I don't have to wade the whole diff
> > to
> > find your one comment.  To answer your question, that is how the rest
> Sorry. Was a mistake. Pressed "Send" too early.
> > of
> > the code is written right now so I just followed that style.  Please
> > feel free to write a patch.  Of course having to look up the name
> My mailer can't append files right now (broken D-Bus). Inline text ok?

Inline is never ok as many mailer will mangle the patch.  The point is
moot though.  Havoc said in so many words that this should not be
changed because it makes the code a little less clear.

-- 
John (J5) Palmieri <johnp at redhat.com>



More information about the dbus mailing list