[PATCH] do not call _dbus_warn_check_failed on checks

[Frederic Crozat]

Le mardi 14 novembre 2006 à 15:34 +0100, Timo Hoenig a écrit :
> Hi Frederic,
> 
> On Tue, 2006-11-14 at 14:48 +0100, Frederic Crozat wrote:
> > Le mardi 14 novembre 2006 à 13:51 +0100, Timo Hoenig a écrit :
> 
> > > There are distributions out there which get along quite nicely with
> > > system bus restarts once D-Bus is being updated.
> > 
> > Could you share with us how you handle such cases in SUSE ?
> 
> There's no magic actually.
> 
> For the last enterprise release we simply fixed all applications which
> did not survive restarts of the D-Bus system bus.  The patches should be
> upstream by now as this was several months ago.
> 
> This allows us to restart the system bus whenever the worst case
> scenario happens.

Ok, that is what was expected from users (and packagers) : apps should
handle bus restart nicely. Thanks for helping in fixing those problems.

> > > However, I do not share Frederic's POV when it comes down to updating
> > > applications which use the system bus.  The dnotify support in D-Bus
> > > works nicely and I have never seen problems with regard to updating the
> > > bus policy at runtime (read: without restarting the system bus in %
> > > post).
> > 
> > Well, maybe I was a little outdated concerning dbus support about
> > configuration change. But from reading dbus-daemon manpage, it isn't
> > really explicit about transparent management of config file.
> 
> Agreed.  The warning with regard of the partial reload could be verbose;
> no idea what the 'partially' actually encompasses.

Good that I'm not the only one wondering about that :)

> > But I'll be more than happy to remove all system dbus restart in all
> > Mandriva packages %post EXCEPT dbus package (of course).
> 
> Just make sure that dnotify is enabled during build.

It is. I'm going to do a nice cleanup in cooker.

Now, we just need to add inotify support in dbus too.. RML, where are
you ? :)

-- 
Frederic Crozat <fcrozat at mandriva.com>
Mandriva