[RFC-PATCH] uninitialized variable in dbus_g_proxy_end_call_internal

Chia-I Wu olvaffe at gmail.com
Mon Dec 31 12:31:46 PST 2007


Hi all,

In dbus_g_proxy_end_call_internal of libdbus-glib, args_unwind is used
uninitialized.  Other than that, va_end is called on args while it
should not.  This patch fixes the two issues.

A third issue is that, when dbus message has more arguments than
expected, the processed arguments should not be freed unconditionally.
They should be restored back to GValue and g_value_unset'ed.  A variant
of _dbus_gvalue_take may do the job, but it seems very hacky.  I choose
to leave the processed arguments untouched (leaks!).  Is it ok?

-- 
Regards,
olv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dbus_g_proxy_end_call_internal-uninitialized-variable.patch
Type: text/x-diff
Size: 926 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/dbus/attachments/20080101/63e65016/attachment.patch 


More information about the dbus mailing list